Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Polish the UI for the log entry examples in the anomaly table #82139

Merged
merged 10 commits into from
Nov 26, 2020
Merged

[Logs UI] Polish the UI for the log entry examples in the anomaly table #82139

merged 10 commits into from
Nov 26, 2020

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Oct 30, 2020 •
edited
Loading

Summary

Closes #72600.

This PR polishes the UI for the log examples in the anomaly table.

  • With examples:

Screenshot 2020-10-30 at 15 20 01

  • With no examples:

Screenshot 2020-10-30 at 15 21 48

Checklist

  • Headline should be xsmall
  • Number of messages in the stats should be xsmall
  • the description if there are no examples should be set to text-align: left
  • the reload button needs a bit of adjustment so it's not cut-off when hovering
  • rethink the format of the no. of messages

@afgomez afgomez added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 30, 2020
@afgomez afgomez added this to the Logs UI 7.11 milestone Oct 30, 2020
@afgomez afgomez requested a review from a team as a code owner October 30, 2020 14:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez
Copy link
Contributor Author

afgomez commented Nov 3, 2020

@elasticmachine merge upstream

katrin-freihofner
katrin-freihofner approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@katrin-freihofner katrin-freihofner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ looks great!

@afgomez afgomez changed the title [Logs UI] Polish theUI for the log entry examples in the anomaly table [Logs UI] Polish the UI for the log entry examples in the anomaly table Nov 5, 2020
@weltenwort
Copy link
Member

@elasticmachine merge upstream

@weltenwort
Copy link
Member

@elasticmachine merge upstream

@weltenwort weltenwort self-requested a review November 23, 2020 15:05
@afgomez
Tweak the layout to prevent button clipping
2baf1cf 
The original solution had problems when resizing the browser window.
This one doesn't
@afgomez
Copy link
Contributor Author

afgomez commented Nov 26, 2020

@elasticmachine merge upstream

weltenwort
weltenwort approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does the trick, thank you! LGTM if CI agrees

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.6MB 2.6MB +138.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit b246701 into elastic:master Nov 26, 2020
@afgomez afgomez deleted the 72600-anomaly-examples-polishing branch November 26, 2020 13:18
afgomez pushed a commit to afgomez/kibana that referenced this pull request Nov 26, 2020
@kibanamachine
[Logs UI] Polish the UI for the log entry examples in the anomaly tab…
2b67fa5 
…le (elastic#82139)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@afgomez afgomez mentioned this pull request Nov 26, 2020
Merged
afgomez pushed a commit that referenced this pull request Nov 26, 2020
@kibanamachine
[7.x] [Logs UI] Polish the UI for the log entry examples in the anoma…
328d147 
…ly table (#82139) (#84411)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 30, 2020
@gmmorris
Merge branch 'master' into alerts/custom-recovery-action-group
09732bd 
* master:
  [Security Solution] Exceptions Cypress tests (elastic#81759)
  [ML] Fix spaces job ID check (elastic#84404)
  [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062)
  skip flaky suite (elastic#84440)
  skip flaky suite (elastic#84445)
  [APM] Fix missing `service.node.name` (elastic#84269)
  Upgrade fp-ts to 2.8.6 (elastic#83866)
  Added data streams privileges to better control delete actions in UI (elastic#83573)
  Improve short-url redirect validation (elastic#84366)
  TSVB offsets (elastic#83051)
  [Discover] Fix navigating back when changing index pattern (elastic#84061)
  [Logs UI] Polish the UI for the log entry examples in the anomaly table (elastic#82139)
  [Logs UI] Limit the height of the "view in context" container (elastic#83178)
  [Application Usage] Update `schema` with new `fleet` rename (elastic#84327)
  fix identation in list (elastic#84301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katrin-freihofner katrin-freihofner katrin-freihofner approved these changes

@weltenwort weltenwort weltenwort approved these changes

Assignees
No one assigned
Labels
Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.11
Development

Successfully merging this pull request may close these issues.

[Logs UI] anomaly view improvements
5 participants
@afgomez @elasticmachine @weltenwort @kibanamachine @katrin-freihofner