Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Build docker image during packer_cache #82145

Merged
merged 6 commits into from
Nov 18, 2020
Merged

[CI] Build docker image during packer_cache #82145

merged 6 commits into from
Nov 18, 2020

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Oct 30, 2020 •
edited
Loading

See https://kibana-ci.elastic.co/job/elastic+kibana+master/9283/execution/node/116/log/
and https://docs.docker.com/docker-hub/download-rate-limit/

Unrelated, but two good reasons to just go ahead and bake the built image into the packer cache image.

Docker will gradually introduce these rate limits starting November 2nd, 2020.

Tested with this here

@brianseeders brianseeders added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 30, 2020
@brianseeders brianseeders marked this pull request as ready for review October 30, 2020 17:54
@brianseeders brianseeders requested a review from a team as a code owner October 30, 2020 17:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

mistic
mistic approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianseeders
Copy link
Contributor Author

@elasticmachine merge upstream

spalger
spalger approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apmmachine
Copy link
Contributor

💚 Build Succeeded

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders brianseeders merged commit 7d9f460 into elastic:master Nov 18, 2020
This was referenced Nov 18, 2020
Merged
Merged
brianseeders added a commit to brianseeders/kibana that referenced this pull request Nov 18, 2020
@brianseeders
[CI] Build docker image during packer_cache (elastic#82145)
8e3ba08 
# Conflicts:
#	.ci/packer_cache_for_branch.sh
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 18, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-metrics-t…
fe54d88 
…o-node-details

* 'master' of github.com:elastic/kibana:
  Derive the port from the protocol in cases where it's not explicitly stated (elastic#83583)
  [CI] Build docker image during packer_cache (elastic#82145)
  [esaggs][inspector]: Refactor to prep for esaggs move to server. (elastic#83199)
brianseeders added a commit that referenced this pull request Nov 19, 2020
@brianseeders
[CI] Build docker image during packer_cache (#82145) (#83667)
71fe551
brianseeders added a commit that referenced this pull request Nov 19, 2020
@brianseeders
[CI] Build docker image during packer_cache (#82145) (#83664)
19ef608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.1 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brianseeders @elasticmachine @apmmachine @kibanamachine @spalger @mistic