Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Replace AgentAssetType enum with new approach #82387

Merged
merged 4 commits into from
Nov 3, 2020
Merged

[Ingest Manager] Replace AgentAssetType enum with new approach #82387

merged 4 commits into from
Nov 3, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Nov 2, 2020

Summary

Expands on pattern added in #82188

AgentAssetType enum is only used as part of a single type definition

@jfsiii jfsiii requested a review from a team November 2, 2020 23:37
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jfsiii jfsiii added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.11.0 labels Nov 2, 2020
@jfsiii
Copy link
Contributor Author

jfsiii commented Nov 3, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
ingestManager 386.0KB 385.9KB -86.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit a49473b into elastic:master Nov 3, 2020
@jfsiii jfsiii self-assigned this Nov 3, 2020
@jfsiii jfsiii mentioned this pull request Nov 4, 2020
Merged
jfsiii pushed a commit that referenced this pull request Nov 5, 2020
[Ingest Manager] Replace AgentAssetType enum with new approach (#82387)…
087d057 
… (#82673)

## Summary

Expands on pattern added in #82188

`AgentAssetType` `enum` is only used as part of a single type definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skh skh skh approved these changes

Assignees

@jfsiii jfsiii

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jfsiii @elasticmachine @kibanamachine @skh