Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add descriptions to alert types (#81850) #82481

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Nov 3, 2020

Backports the following commits to 7.x:

* Initial attempt at adding descriptions to alert types

* Fix typecheck failures

* Fix i18n check

* Fix failing jest test

* Fix i18n check again

* Apply changes for Uptime

* Update x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts

Co-authored-by: Casper Hübertz <casper@formgeist.com>

* Update x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts

Co-authored-by: Casper Hübertz <casper@formgeist.com>

* Fix jest test

* Update geo threshold description

* Update description of some alert types based on feedback from Gail

* Update description of some alert types based on feedback from Gail

* Fix i18n

* Fix i18n

* Fix ESLint

* Update some copy

* Update uptime alert description

* Fix typos

Co-authored-by: Casper Hübertz <casper@formgeist.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
monitoring 962.1KB 962.6KB +467.0B

page load bundle size

id before after diff
apm 47.3KB 48.2KB +884.0B
infra 172.7KB 173.2KB +572.0B
monitoring 33.3KB 35.7KB +2.4KB
triggersActionsUi 132.0KB 132.5KB +510.0B
uptime 23.9KB 24.7KB +834.0B
total +5.1KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote merged commit b0d7421 into elastic:7.x Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants