Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [IngestManager] Convert AgentPolicyStatus from enum to type (#82186) #82653

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Nov 4, 2020

Backports the following commits to 7.x:

@jfsiii jfsiii added the backport label Nov 4, 2020
## Summary

Expands on pattern added in #82188

Split `enum AgentPolicyStatus` into `type AgentPolicyStatus` and JS value `agentPolicyStatuses`. Still have type safety

<img width="604" alt="Screen Shot 2020-11-02 at 6 05 29 PM" src="https://user-images.githubusercontent.com/57655/97929572-7ba8d100-1d37-11eb-88db-3785381ebfbf.png">
<img width="931" alt="Screen Shot 2020-11-02 at 6 08 41 PM" src="https://user-images.githubusercontent.com/57655/97929574-7ba8d100-1d37-11eb-8db5-ee5d07d171c6.png">
<img width="605" alt="Screen Shot 2020-11-02 at 6 09 02 PM" src="https://user-images.githubusercontent.com/57655/97929575-7c416780-1d37-11eb-8297-e90ffe695161.png">
@jfsiii jfsiii force-pushed the backport/7.x/pr-82186 branch from 6a5ebc7 to 6f465db Compare November 4, 2020 20:31
@jfsiii
Copy link
Contributor Author

jfsiii commented Nov 4, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
ingestManager 385.8KB 386.0KB +186.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit ec5163c into elastic:7.x Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants