Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Fleet] Allow snake cased Kibana assets (#77515)" #82706

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Revert "[Fleet] Allow snake cased Kibana assets (#77515)" #82706

merged 1 commit into from
Nov 5, 2020

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Nov 5, 2020

This reverts commit 1cd477a.

Reverting because a file has an * in the filename and it was breaking Windows users from pulling in changes correctly.

@crob611 crob611 requested a review from a team November 5, 2020 12:19
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@crob611 crob611 merged commit bc05e79 into elastic:master Nov 5, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ingestManager 1.2MB 1.2MB +4.0B

page load bundle size

id before after diff
ingestManager 386.4KB 385.8KB -609.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

crob611 pushed a commit to crob611/kibana that referenced this pull request Nov 5, 2020
Revert "Revert "[Fleet] Allow snake cased Kibana assets (elastic#77515)…
e695e69 
…" (elastic#82706)"

This reverts commit bc05e79.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 5, 2020
@gmmorris
Merge branch 'master' into alerts/assign-action-groups
401d99f 
* master:
  Revert "[Fleet] Allow snake cased Kibana assets (elastic#77515)" (elastic#82706)
jfsiii pushed a commit that referenced this pull request Nov 5, 2020
[Fleet] Remove asterix from test file name (#82721)
6437139 
* Revert "Revert "[Fleet] Allow snake cased Kibana assets (#77515)" (#82706)"

This reverts commit bc05e79.

* Rename test index pattern
crob611 pushed a commit to crob611/kibana that referenced this pull request Nov 6, 2020
[Fleet] Remove asterix from test file name (elastic#82721)
8f95f58 
* Revert "Revert "[Fleet] Allow snake cased Kibana assets (elastic#77515)" (elastic#82706)"

This reverts commit bc05e79.

* Rename test index pattern
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 9, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 82706 or prevent reminders by adding the backport:skip label.

crob611 pushed a commit that referenced this pull request Nov 9, 2020
@kibanamachine
[Fleet] Remove asterix from test file name (#82721) (#82884)
31c49f3 
* Revert "Revert "[Fleet] Allow snake cased Kibana assets (#77515)" (#82706)"

This reverts commit bc05e79.

* Rename test index pattern

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 82706 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 82706 or prevent reminders by adding the backport:skip label.

@skh skh added the backport:skip This commit does not require backporting label Nov 11, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 11, 2020
@skh
Copy link
Contributor

skh commented Nov 11, 2020

Adding backport:skip as the reverted PR wasn't backported either. @crob611 please correct me if I'm wrong.

@crob611
Copy link
Contributor Author

crob611 commented Nov 11, 2020

Ahh yes thanks @skh

Correct, I did not backport the commit that was reverted, and only backported the "Unrevert and fix the issue" commit #82884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crob611 @elasticmachine @kibanamachine @skh