Added ability to fire actions when an alert instance is resolved #82799

YulNaumenko · 2020-11-06T01:17:01Z

elasticmachine · 2020-11-09T06:04:19Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

x-pack/plugins/alerts/server/alert_type_registry.ts

ymao1 · 2020-11-10T14:33:35Z

x-pack/plugins/alerts/server/task_runner/task_runner.ts

@@ -225,6 +226,14 @@ export class TaskRunner {
      alertInstance.hasScheduledActions()
    );
    const currentAlertInstanceIds = Object.keys(instancesWithScheduledActions);
+
+    scheduleActionsForResolvedInstances(


I believe this will send a notification for a resolved instance event if the alert instance is muted (or if all instances are muted). Is that the expected behavior?

Correct, we shouldn't be scheduling actions if the instance or alert is throttled/muted. We may want to make that check check a reusable function somewhere, wherever it's done today, so other call sites (like this one), can use it. Either that, or figure out how to include these new actions to be scheduled in the same place they are done today - sorry I haven't looked at where these places might be yet, but can poke around a bit more if you want - LMK.

Correct, we shouldn't be scheduling actions if the instance or alert is throttled/muted

I believe only muted since throttle resets when action group changes?

Great catch! By the way, I'm not sure about the reusable function here - we need to identify if the alert is muted to skip the whole scheduleActionsForResolvedInstances call and passing down the list of mutedInstanceIds to skip it in the schedule function as well. I think we already have this information on the current function level about the specific alert. Or we should get here the most fresh by calling alertsClient get by alertId?

I've tested it with the UI PR part using PagerDuty incidents and it works fine now with handling the mute state. Will provide the api integration test as well

x-pack/plugins/triggers_actions_ui/public/application/lib/alert_api.ts

…-action-group # Conflicts: # x-pack/plugins/alerts/server/task_runner/task_runner.ts

mikecote

Changes LGTM! Left a few nits.

One question I had is, should we prevent alert types from calling scheduleActions with the resolved action group?

x-pack/plugins/alerts/common/index.ts

x-pack/plugins/alerts/server/alert_type_registry.ts

x-pack/plugins/alerts/server/task_runner/task_runner.ts

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/alerts_base.ts

…-action-group # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

gmmorris

LGTM.
Most of the things I noticed Mike seems to have noted too, so nothing much to add beyond a couple of nits. :)

x-pack/plugins/alerts/server/alert_type_registry.ts

gmmorris · 2020-11-12T17:13:44Z

x-pack/plugins/alerts/server/task_runner/task_runner.ts

+      context: {},
+      state: {},


Wondering if we're going to find the empty context and state to be a problem 🤔
Should we perhaps remove the values expected in context and stat from the template variables in the UI?
Otherwise users might try to use them in actions when attaching to Resolved, no?

I did it in the UI PR

…ction-group

kibanamachine · 2020-11-14T00:35:40Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 78a15c9

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`alerts`	26	27	+1

Distributable file count

id	before	after	diff
`default`	42859	42860	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`alerts`	88.4KB	89.4KB	+1.0KB

History

💔 Build #87794 failed b4dc1f5
💔 Build #87542 failed f781dcb
💚 Build #87278 succeeded 676d8f1
💔 Build #87208 failed 8f48a39
💔 Build #87203 failed 378fa7c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…stic#82799) * Added ability to fire actions when an alert instance is resolved * Fixed due to comments * Fixed merge issue * Fixed tests and added skip for muted resolve * added test for muted alert * Fixed due to comments * Fixed registry error message * Fixed jest test

) (#83381) * Added ability to fire actions when an alert instance is resolved * Fixed due to comments * Fixed merge issue * Fixed tests and added skip for muted resolve * added test for muted alert * Fixed due to comments * Fixed registry error message * Fixed jest test

* master: Migrate `/translations` route to core (elastic#83280) [APM] Ensure APM jest script can run (elastic#83398) [Uptime] Monitor status alert use url as instance (elastic#81736) [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259) TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964) [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139) Skips Vega test skip flaky suite (elastic#79967) [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020) Added ability to fire actions when an alert instance is resolved (elastic#82799) [ML] Adds functional tests for the index data visualizer card contents (elastic#83174)

… into add-logs-to-node-details * 'add-logs-to-node-details' of github.com:phillipb/kibana: fix tall vislib charts in visualize (elastic#83340) [Lens] Avoid unnecessary data fetching on dimension flyout open (elastic#82957) [Security Solution][Case] Change case connector minimum required license to basic (elastic#83401) fix logstash central pipeline management test (elastic#83281) [Search] Send to background UI (elastic#81793) Migrate `/translations` route to core (elastic#83280) [APM] Ensure APM jest script can run (elastic#83398) [Uptime] Monitor status alert use url as instance (elastic#81736) [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259) TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964) [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139) Skips Vega test skip flaky suite (elastic#79967) [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020) Added ability to fire actions when an alert instance is resolved (elastic#82799)

Added ability to fire actions when an alert instance is resolved

fad1fe2

YulNaumenko self-assigned this Nov 6, 2020

YulNaumenko linked an issue Nov 6, 2020 that may be closed by this pull request

Static resolved action group to fire when an alert instance is resolved #82366

Closed

YulNaumenko mentioned this pull request Nov 6, 2020

Ability to fire actions when an alert instance is resolved #49405

Closed

2 tasks

YulNaumenko marked this pull request as ready for review November 9, 2020 06:03

YulNaumenko requested a review from a team as a code owner November 9, 2020 06:03

YulNaumenko added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Nov 9, 2020

YulNaumenko added v7.11.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 9, 2020

ymao1 reviewed Nov 10, 2020

View reviewed changes

YulNaumenko added 4 commits November 10, 2020 07:00

Merge remote-tracking branch 'upstream/master' into alerting-resolved…

39f8587

…-action-group # Conflicts: # x-pack/plugins/alerts/server/task_runner/task_runner.ts

Fixed due to comments

378fa7c

Fixed merge issue

8f48a39

Fixed tests and added skip for muted resolve

676d8f1

YulNaumenko requested review from pmuellr, mikecote and ymao1 November 11, 2020 05:58

added test for muted alert

f781dcb

mikecote approved these changes Nov 12, 2020

View reviewed changes

gmmorris approved these changes Nov 12, 2020

View reviewed changes

YulNaumenko added 4 commits November 12, 2020 15:37

Fixed due to comments

53ac140

Fixed registry error message

b4dc1f5

Merge remote-tracking branch upstream/master into alerting-resolved-a…

2d8f830

…ction-group

Fixed jest test

78a15c9

YulNaumenko merged commit 4ad3cef into elastic:master Nov 14, 2020

YulNaumenko mentioned this pull request Nov 14, 2020

[7.x] Added ability to fire actions when an alert instance is resolved (#82799) #83381

Merged

YulNaumenko mentioned this pull request Nov 16, 2020

[Alerts] Prevent alert types from calling scheduleActions with the resolved action group #83501

Closed

chrisronline mentioned this pull request Nov 17, 2020

[Monitoring] Resolve alerts properly #80398

Open

YulNaumenko added the needs_docs label Nov 19, 2020

ymao1 mentioned this pull request Dec 18, 2020

Action on status-change failing in Logs alerts #86507

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added ability to fire actions when an alert instance is resolved #82799

Added ability to fire actions when an alert instance is resolved #82799

YulNaumenko commented Nov 6, 2020

elasticmachine commented Nov 9, 2020

ymao1 Nov 10, 2020

pmuellr Nov 10, 2020

mikecote Nov 10, 2020 •

edited

Loading

YulNaumenko Nov 11, 2020

YulNaumenko Nov 11, 2020

mikecote left a comment

gmmorris left a comment

gmmorris Nov 12, 2020

YulNaumenko Nov 12, 2020 •

edited

Loading

kibanamachine commented Nov 14, 2020

Added ability to fire actions when an alert instance is resolved #82799

Added ability to fire actions when an alert instance is resolved #82799

Conversation

YulNaumenko commented Nov 6, 2020

elasticmachine commented Nov 9, 2020

ymao1 Nov 10, 2020

Choose a reason for hiding this comment

pmuellr Nov 10, 2020

Choose a reason for hiding this comment

mikecote Nov 10, 2020 • edited Loading

Choose a reason for hiding this comment

YulNaumenko Nov 11, 2020

Choose a reason for hiding this comment

YulNaumenko Nov 11, 2020

Choose a reason for hiding this comment

mikecote left a comment

Choose a reason for hiding this comment

gmmorris left a comment

Choose a reason for hiding this comment

gmmorris Nov 12, 2020

Choose a reason for hiding this comment

YulNaumenko Nov 12, 2020 • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Nov 14, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Distributable file count

Page load bundle

History

mikecote Nov 10, 2020 •

edited

Loading

YulNaumenko Nov 12, 2020 •

edited

Loading