-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSVB doesn't communicate it's index-patterns to dashboard #82964
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e2e02fe
TSVB doesn't communicate it's index-patterns to dashboard
alexwizp fbec631
useCustomSearchSource -> getUsedIndexPattern
alexwizp 49623c9
fix CI
alexwizp a17dcad
Merge branch 'master' into 81476
kibanamachine ec1fb8a
Merge branch 'master' into 81476
kibanamachine 422a5cd
Merge branch 'master' into 81476
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,3 +18,4 @@ | |
*/ | ||
|
||
export const MAX_BUCKETS_SETTING = 'metrics:max_buckets'; | ||
export const INDEXES_SEPARATOR = ','; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One idea that came to mind:
I'm wondering if, instead of having two sources of truth in a vis for the index pattern (either
vis.data.indexPattern
ORvis.type.getUsedIndexPattern
), it would be cleaner to make a change invis
itself so thatvis.data.indexPattern
always reads fromvis.type.getUsedIndexPattern
.In
vis.ts
we could do something like:Then on the vis type:
Then on the vis type,
getIndexPattern
is optional, and defaults to the logic that's currently invis.ts
:kibana/src/plugins/visualizations/public/vis.ts
Lines 140 to 153 in a17dcad
WDYT @alexwizp? Do you think that would work / make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty the same idea was implemented in my initial commit(e2e02fe), but after discussing it @ppisljar we decided to don't modify
vis.setState
method.