Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guide to be explicit about creating a fork prior to cloning #8305

Merged

Conversation

stacey-gammon
Copy link
Contributor

Then other github newbies like me won't create and push branches directly to the Kibana repo without going through a pull request. Doh!

This is my first PR so please let me know if I am doing something wrong, or if anything can be improved. :)

@karmi
Copy link

karmi commented Sep 15, 2016

Hi @stacey-gammon, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@stacey-gammon
Copy link
Contributor Author

Done!

@ycombinator ycombinator self-assigned this Sep 15, 2016
@ycombinator
Copy link
Contributor

LGTM!

@ycombinator ycombinator removed their assignment Sep 15, 2016
@stacey-gammon stacey-gammon merged commit 84a504e into elastic:master Sep 15, 2016
@stacey-gammon stacey-gammon deleted the update-contributing-guide branch September 15, 2016 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants