Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logstash central pipeline management test #83281

Merged
merged 3 commits into from
Nov 16, 2020
Merged

fix logstash central pipeline management test #83281

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc6c33d
fix flaky test #83231
kaisecheng Nov 12, 2020
fd27be7
fix flaky test #83231
kaisecheng Nov 12, 2020
4af1af8
Merge branch 'master' into fix/logstash-pipeline-test
kibanamachine Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions x-pack/test/functional/apps/logstash/pipeline_create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/

import expect from '@kbn/expect';
import { omit } from 'lodash';

export default function ({ getService, getPageObjects }) {
const browser = getService('browser');
Expand All @@ -15,8 +16,7 @@ export default function ({ getService, getPageObjects }) {
const PageObjects = getPageObjects(['logstash']);
const retry = getService('retry');

// FLAKY: https://github.com/elastic/kibana/issues/83231
describe.skip('pipeline create new', () => {
describe('pipeline create new', () => {
let originalWindowSize;

before(async () => {
Expand Down Expand Up @@ -89,14 +89,16 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.logstash.gotoPipelineList();
await pipelineList.assertExists();
const originalRows = await pipelineList.readRows();
const originalRowsWithoutTime = originalRows.map((row) => omit(row, 'lastModified'));

await PageObjects.logstash.gotoNewPipelineEditor();
await pipelineEditor.clickCancel();

await retry.try(async () => {
await pipelineList.assertExists();
const currentRows = await pipelineList.readRows();
expect(originalRows).to.eql(currentRows);
const currentRowsWithoutTime = currentRows.map((row) => omit(row, 'lastModified'));
expect(originalRowsWithoutTime).to.eql(currentRowsWithoutTime);
});
});
});
Expand Down