Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Improve icons for all layer types #83503

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

elizabetdev
Copy link
Contributor

Summary

Closes #82076

This PR enhance all icons, so they can look similar to the ES-sources.

All layers icons@2x

I also added an icon for the Tracks Layer (#76572) that can be found here: x-pack/plugins/maps/public/classes/layers/icons/tracks_layer_icon.tsx

Checklist

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 627 631 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.8MB 2.8MB +12.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 150.7KB 151.0KB +264.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elizabetdev elizabetdev added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Nov 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elizabetdev elizabetdev added v7.10.1 v7.11.0 enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes labels Nov 17, 2020
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks great!

thanks for adding the TracksLayerIcon as well (#76572 (comment))

@elizabetdev elizabetdev merged commit 292dbcc into elastic:master Nov 17, 2020
elizabetdev added a commit to elizabetdev/kibana that referenced this pull request Nov 17, 2020
* Improve icons for all layer types

* EMS boundaries icon

* Adding tracks layer icon
elizabetdev added a commit that referenced this pull request Nov 17, 2020
* Improve icons for all layer types

* EMS boundaries icon

* Adding tracks layer icon
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 17, 2020
* master: (51 commits)
  [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439)
  adds xpack.security.authc.selector.enabled setting (elastic#83551)
  skip flaky suite (elastic#77279)
  [ML] Improve support for script and aggregation fields in anomaly detection jobs (elastic#81923)
  [Workplace Search] Migrate SourcesLogic from ent-search (elastic#83544)
  [ML] Add UI test for feature importance features (elastic#82677)
  [Maps] Improve icons for all layer types (elastic#83503)
  Replace experimental badge with Beta (elastic#83468)
  [Fleet][EPM] Unified install and archive (elastic#83384)
  Move src/legacy/server/keystore to src/cli (elastic#83483)
  Used SO for saving the API key IDs that should be deleted (elastic#82211)
  [Uptime] Mock implementation to account for math flakiness test (elastic#83535)
  [Workplace Search] Enable check for org context based on URL (elastic#83487)
  [App Search] Added all Document related routes and logic (elastic#83324)
  [Alerting UI] Fix console error when setting connector params (elastic#83333)
  [Discover] Allow custom name for fields via index pattern field management (elastic#70039)
  [Uptime] Fix monitor list down histogram (elastic#83411)
  remove headers timeout hack, rely on nodejs timeouts (elastic#83419)
  [ML] Update console autocomplete for ML data frame evaluate API (elastic#83151)
  [Lens] Color in dimension trigger (elastic#76871)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes v7.10.1 v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Improve icons for all layer types
5 participants