Update typescript eslint to v4.8 #83520

mshustov · 2020-11-17T08:57:59Z

Summary

Blocks: #83397

Updates @typescript-eslint to version compatible with TypeScript 4.1
Switches from no-shadow to @typescript-eslint/no-shadow checking types as well
Turns off no-undef for TS files. TypeScript fails in such cases anyway. Incorrectly triggers no-undef and no-redeclare in some cases typescript-eslint/typescript-eslint#2477 (comment)
Updates eslint-plugin-react-hooks to version compatible with @typescript-eslint@v4
Removes excessive disabling instructions
Adds eslint-disable-next-line react-hooks/exhaustive-deps for newly detected problems: The 'XX' makes the dependencies of useMemo Hook (at line YY) change on every render. Move it inside the useMemo callback. Alternatively, wrap the initialization of 'XX' in its own useMemo() Hook.(react-hooks/exhaustive-deps). These problems exist in the codebase for a while, so I decided to mute them and allow plugin owners to fix them later.

use type-aware @typescript-eslint/no-shadow instead of no-shadow. do not use no-undef, rely on TypeScript instead

elasticmachine · 2020-11-17T08:58:02Z

Pinging @elastic/kibana-platform (Team:Platform)

elasticmachine · 2020-11-17T08:58:05Z

Pinging @elastic/ingest-management (Team:Ingest Management)

elasticmachine · 2020-11-17T08:58:05Z

Pinging @elastic/apm-ui (Team:apm)

mshustov · 2020-11-17T08:59:37Z

.eslintrc.js

@@ -998,7 +999,8 @@ module.exports = {
        'no-shadow-restricted-names': 'error',
        'no-sparse-arrays': 'error',
        'no-this-before-super': 'error',
-        'no-undef': 'error',
+        // rely on typescript
+        'no-undef': 'off',


there are no *.js files but scripts/check_circular_deps

mshustov · 2020-11-17T08:59:46Z

.eslintrc.js

@@ -863,7 +863,8 @@ module.exports = {
        'no-shadow-restricted-names': 'error',
        'no-sparse-arrays': 'error',
        'no-this-before-super': 'error',
-        'no-undef': 'error',
+        // rely on typescript
+        'no-undef': 'off',


there are no *.js files but scripts/**

pgayvallet · 2020-11-17T11:56:08Z

src/core/server/http/router/validator/validator.ts

-  public static from<P = {}, Q = {}, B = {}>(
-    opts: RouteValidator<P, Q, B> | RouteValidatorFullConfig<P, Q, B>
+  public static from<_P = {}, _Q = {}, _B = {}>(
+    opts: RouteValidator<_P, _Q, _B> | RouteValidatorFullConfig<_P, _Q, _B>


Is that really an opinionated decision from the @typescript-eslint/no-shadow rules? There is technically no shadowing between the class/instance generics and a static function's...

mikecote

Alerting team related code LGTM

afgomez

Infra changes LGTM

lukeelmers

app arch updates LGTM

jen-huang

Fleet changes LGTM

mbondyra

KibanaApp changes look good 👍

sebelga

ES UI team changes LGTM, thanks for making those changes! 👍

clintandrewhall

LGTM!

kibanamachine · 2020-11-18T16:55:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 23aba70

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	692.0KB	692.0KB	-2.0B
`securitySolution`	7.9MB	7.9MB	+28.0B
total			+26.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`upgradeAssistant`	60.5KB	60.5KB	-2.0B

History

💔 Build #88560 failed b2b6cd3
💚 Build #88271 succeeded 01b9c98
💔 Build #88249 failed c3aab72
💔 Build #88237 failed bce5239

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* update deps * update rules use type-aware @typescript-eslint/no-shadow instead of no-shadow. do not use no-undef, rely on TypeScript instead * fix or mute all lint errors * react-hooks eslint plugin fails on ? syntax * fix wrong typings in viz * remove React as a global type * fix eslint errors * update version to 4.8.1 * fix a new error

… into add-logs-to-node-details * 'add-logs-to-node-details' of github.com:phillipb/kibana: (87 commits) [Maps] Add 'crossed' & 'exited' events to tracking alert (elastic#82463) Updating code-owners to use new core/app-services team names (elastic#83731) Add Managed label to data streams and a view switch for the table (elastic#83049) [Maps] Add query bar inputs to geo threshold alerts tracked points & boundaries (elastic#80871) fix(NA): search examples kibana version declaration (elastic#83182) Fixed console error, which appears when saving changes in Edit Alert flyout (elastic#83610) [Alerting] Add `alert.updatedAt` field to represent date of last user edit (elastic#83578) Not resetting server log level if level is defined (elastic#83651) disable incremenetal build for legacy tsconfig.json (elastic#82986) [Workplace Search] Migrate SourceLogic from ent-search (elastic#83593) [Workplace Search] Port Box changes from ent-search (elastic#83675) [APM] Improve router types (elastic#83620) Bump flat to v4.1.1 (elastic#83647) Bump y18n@5 to v5.0.5 (elastic#83644) Bump jsonpointer to v4.1.0 (elastic#83641) Bump is-my-json-valid to v2.20.5 (elastic#83642) [Telemetry] Move Monitoring collection strategy to a collector (elastic#82638) Update typescript eslint to v4.8 (elastic#83520) [ML] Persist URL state for Anomaly detection jobs using metric function (elastic#83507) [ML] Performance improvements to annotations editing in Single Metric Viewer & buttons placement (elastic#83216) ...

* update deps * update rules use type-aware @typescript-eslint/no-shadow instead of no-shadow. do not use no-undef, rely on TypeScript instead * fix or mute all lint errors * react-hooks eslint plugin fails on ? syntax * fix wrong typings in viz * remove React as a global type * fix eslint errors * update version to 4.8.1 * fix a new error

mshustov added 3 commits November 17, 2020 11:41

update deps

2240867

update rules

1acebc0

use type-aware @typescript-eslint/no-shadow instead of no-shadow. do not use no-undef, rely on TypeScript instead

fix or mute all lint errors

bce5239

mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Dependencies v7.11.0 labels Nov 17, 2020

mshustov requested review from a team as code owners November 17, 2020 08:58

mshustov requested a review from a team November 17, 2020 08:58

mshustov requested a review from a team as a code owner November 17, 2020 08:58

mshustov requested a review from a team November 17, 2020 08:58

mshustov requested review from a team as code owners November 17, 2020 08:58

botelastic bot added Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 17, 2020

mshustov commented Nov 17, 2020

View reviewed changes

mshustov added 2 commits November 17, 2020 12:41

react-hooks eslint plugin fails on ? syntax

721267f

fix wrong typings in viz

d2aa382

mshustov added 2 commits November 17, 2020 13:04

remove React as a global type

c3aab72

fix eslint errors

01b9c98

pgayvallet approved these changes Nov 17, 2020

View reviewed changes

mikecote approved these changes Nov 17, 2020

View reviewed changes

afgomez self-requested a review November 17, 2020 15:17

afgomez approved these changes Nov 17, 2020

View reviewed changes

jbudz approved these changes Nov 17, 2020

View reviewed changes

lukeelmers approved these changes Nov 17, 2020

View reviewed changes

jen-huang approved these changes Nov 17, 2020

View reviewed changes

mbondyra approved these changes Nov 18, 2020

View reviewed changes

sebelga approved these changes Nov 18, 2020

View reviewed changes

sorenlouv approved these changes Nov 18, 2020

View reviewed changes

mshustov added 2 commits November 18, 2020 17:30

merge master

118aa14

update version to 4.8.1

b2b6cd3

clintandrewhall approved these changes Nov 18, 2020

View reviewed changes

fix a new error

23aba70

oatkiller approved these changes Nov 18, 2020

View reviewed changes

mshustov merged commit 4917df3 into elastic:master Nov 18, 2020

mshustov deleted the update-typescript-eslint branch November 18, 2020 17:23

mshustov mentioned this pull request Nov 18, 2020

[7.x] Update typescript eslint to v4.8 (#83520) #83677

Merged

spalger mentioned this pull request Nov 18, 2020

[npm] upgrade eslint-plugin-react-hooks #83674

Closed

mshustov added the backported label Nov 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update typescript eslint to v4.8 #83520

Update typescript eslint to v4.8 #83520

mshustov commented Nov 17, 2020 •

edited

Loading

elasticmachine commented Nov 17, 2020

elasticmachine commented Nov 17, 2020

elasticmachine commented Nov 17, 2020

mshustov Nov 17, 2020

mshustov Nov 17, 2020

pgayvallet Nov 17, 2020 •

edited

Loading

mikecote left a comment

afgomez left a comment

lukeelmers left a comment

jen-huang left a comment

mbondyra left a comment

sebelga left a comment

clintandrewhall left a comment

kibanamachine commented Nov 18, 2020

Update typescript eslint to v4.8 #83520

Update typescript eslint to v4.8 #83520

Conversation

mshustov commented Nov 17, 2020 • edited Loading

Summary

elasticmachine commented Nov 17, 2020

elasticmachine commented Nov 17, 2020

elasticmachine commented Nov 17, 2020

mshustov Nov 17, 2020

Choose a reason for hiding this comment

mshustov Nov 17, 2020

Choose a reason for hiding this comment

pgayvallet Nov 17, 2020 • edited Loading

Choose a reason for hiding this comment

mikecote left a comment

Choose a reason for hiding this comment

afgomez left a comment

Choose a reason for hiding this comment

lukeelmers left a comment

Choose a reason for hiding this comment

jen-huang left a comment

Choose a reason for hiding this comment

mbondyra left a comment

Choose a reason for hiding this comment

sebelga left a comment

Choose a reason for hiding this comment

clintandrewhall left a comment

Choose a reason for hiding this comment

kibanamachine commented Nov 18, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

mshustov commented Nov 17, 2020 •

edited

Loading

pgayvallet Nov 17, 2020 •

edited

Loading