Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests - fix esArchive mappings with runtime fields #83530

Merged
merged 5 commits into from
Nov 17, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Nov 17, 2020

Summary

This PR fixes the esArchives that define runtime fields in their mappings.

Details

With a recent ES PR, runtime field definition in mappings has been moved to a separate section. The old mappings are causing failures like this on esArchive load:

Error: [mapper_parsing_exception] No handler for type [runtime] declared on field [runtime_number]

This also causes failures in

@pheyos pheyos added test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 17, 2020
@pheyos pheyos self-assigned this Nov 17, 2020
@pheyos
Copy link
Member Author

pheyos commented Nov 17, 2020

As discussed with @mistic on slack:
The Jenkinsfile modification is only temporary to check if the PR passes on the latest (not yet promoted) ES snapshot

@pheyos pheyos requested a review from a team as a code owner November 17, 2020 14:57
@pheyos pheyos requested a review from legrego November 17, 2020 14:58
@pheyos
Copy link
Member Author

pheyos commented Nov 17, 2020

Pulling in @legrego for review as I can see that you've added the security API test that I'm modifying.

Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes LGTM - thanks!

@mistic
Copy link
Member

mistic commented Nov 17, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 62436e3 into elastic:master Nov 17, 2020
@mistic
Copy link
Member

mistic commented Nov 17, 2020

7.x: 8735b46

mistic pushed a commit to mistic/kibana that referenced this pull request Nov 17, 2020
…c#83530)

* Functional tests - fix esArchive mappings with runtime fields

* Modify jenkinsfile to run with unverified ES snapshot

* Adjust security index fields test for the new mapping structure

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
mistic added a commit that referenced this pull request Nov 17, 2020
#83581)

* Functional tests - fix esArchive mappings with runtime fields

* Modify jenkinsfile to run with unverified ES snapshot

* Adjust security index fields test for the new mapping structure

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 18, 2020
…o-node-details

* 'master' of github.com:elastic/kibana: (65 commits)
  update chromedriver dependency to 87 (elastic#83624)
  [TSVB] use new Search API for rollup search (elastic#83275)
  [TSVB] Y-axis has number formatting not considering all series formatters in the group (elastic#83438)
  [Logs UI] Update <LogStream /> internal state when its props change (elastic#83302)
  Add tag bulk action context menu (elastic#82816)
  [code coverage] adding plugin to flush coverage data (elastic#83447)
  [UsageCollection] Expose `KibanaRequest` to explicitly opted-in collectors (elastic#83413)
  Added eventBus to trigger and listen plotHandler event (elastic#83435)
  [Runtime fields] Editor phase 1 (elastic#81472)
  [Maps] Fix threshold alert issue resolving nested fields (elastic#83577)
  chore(NA): remove usage of unverified es snapshots (elastic#83589)
  [DOCS] Adds Elastic Contributor Program link (elastic#83561)
  Upgrade EUI to v30.2.0 (elastic#82730)
  Don't show loading screen during auto-reload (elastic#83376)
  Functional tests - fix esArchive mappings with runtime fields (elastic#83530)
  [deb/rpm] Create keystore after installation (elastic#76465)
  [rpm] Create default environment file at "/etc/sysconfig/kibana" (elastic#82144)
  [docker] removes workaround for missing crypto-policies-scripts subpackage (elastic#83455)
  [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439)
  adds xpack.security.authc.selector.enabled setting (elastic#83551)
  ...
@pheyos pheyos deleted the fix_archives_with_runtime_fields branch November 19, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants