-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable checking for conflicts when copying saved objects #83575
Merged
Merged
Changes from 19 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
40a9f4c
Add Spaces telemetry data
jportner 10998e4
Disable checking for conflicts by default when copying objects
jportner e8ded81
Add Core telemetry data
jportner ecabf59
Disable checking for conflicts by default when importing objects
jportner 25ee394
Merge branch 'master' into issue-81907-and-82324
kibanamachine 7ecb815
PR review feedback
jportner e716476
i18n check
jportner 8276465
Rename "telemetry data" to "usage stats"
jportner 358940c
Rename usage stats fields
jportner fc123a1
node scripts/check_published_api_changes.js --accept
jportner b2bd013
Merge branch 'master' into pr/jportner/83575
jportner 8bfee38
Tweak usage stats client unit tests
jportner c526e62
More PR review feedback
jportner ec2a77c
Merge branch 'master' into pr/jportner/83575
jportner f9b89a5
Revert "Disable checking for conflicts by default when importing obje…
jportner 9cf6288
Add usage stats fields to differentiate first-party requests
jportner 7129c3b
Merge branch 'master' into issue-81907-and-82324
kibanamachine b9428d3
Merge branch 'master' into pr/jportner/83575
jportner cfcf686
Even more PR review feedback
jportner eb78588
Merge branch 'master' into pr/jportner/83575
jportner 69d7369
Refactor
jportner 60c3820
Use SavedObjectsRepository.incrementCounter()
jportner d1124f8
Merge branch 'master' into pr/jportner/83575
jportner 07cb882
node scripts/check_published_api_changes.js --accept
jportner 787ee5e
Fix usage stats fields
jportner 33b32bb
Merge branch 'master' into pr/jportner/83575
jportner 8cd3433
node scripts/check_published_api_changes.js --accept
jportner 21188ed
Merge branch 'master' into pr/jportner/83575
jportner 60de78c
Apply suggestions from code review
jportner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
/** @internal */ | ||
export const CORE_USAGE_STATS_TYPE = 'core-usage-stats'; | ||
|
||
/** @internal */ | ||
export const CORE_USAGE_STATS_ID = 'core-usage-stats'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { SavedObjectsType } from '../saved_objects'; | ||
import { CORE_USAGE_STATS_TYPE } from './constants'; | ||
|
||
/** @internal */ | ||
export const coreUsageStatsType: SavedObjectsType = { | ||
name: CORE_USAGE_STATS_TYPE, | ||
hidden: true, | ||
namespaceType: 'agnostic', | ||
mappings: { | ||
dynamic: false, // we aren't querying or aggregating over this data, so we don't need to specify any fields | ||
properties: {}, | ||
}, | ||
}; |
32 changes: 32 additions & 0 deletions
32
src/core/server/core_usage_stats/core_usage_stats_client.mock.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { CoreUsageStatsClient } from '.'; | ||
|
||
const createUsageStatsClientMock = () => | ||
(({ | ||
getUsageStats: jest.fn().mockResolvedValue({}), | ||
incrementSavedObjectsImport: jest.fn().mockResolvedValue(null), | ||
incrementSavedObjectsResolveImportErrors: jest.fn().mockResolvedValue(null), | ||
incrementSavedObjectsExport: jest.fn().mockResolvedValue(null), | ||
} as unknown) as jest.Mocked<CoreUsageStatsClient>); | ||
|
||
export const coreUsageStatsClientMock = { | ||
create: createUsageStatsClientMock, | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow I forgot to document this when I added this option 🙈 Added it now!