Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[index patterns] Field custom name => custom label #83717

Merged
merged 3 commits into from
Nov 19, 2020
Merged

[index patterns] Field custom name => custom label #83717

merged 3 commits into from
Nov 19, 2020

Conversation

mattkime
Copy link
Contributor

Summary

Renaming the field custom name to custom label. Custom label is a bit more specific as this is only used for display in the UI. In the future it will be possible to define new fields on the index pattern and the name of those fields will be defined by the user making 'custom name' insufficiently distinct.

Checklist

@mattkime mattkime requested a review from a team as a code owner November 18, 2020 20:57
@mattkime mattkime added release_note:skip Skip the PR/issue when compiling release notes Team:AppArch labels Nov 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 v7.11.0 labels Nov 18, 2020
@mattkime mattkime requested a review from kertal November 19, 2020 04:04
kertal
kertal approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, on more change it this should be fine, think that labeling it label is much better 👍

src/plugins/index_pattern_management/public/components/field_editor/field_editor.tsx Outdated Show resolved Hide resolved
streamich
streamich approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM.

mattkime and others added 2 commits November 19, 2020 13:49
@mattkime @kertal
Update src/plugins/index_pattern_management/public/components/field_e…
d07fec5 
…ditor/field_editor.tsx

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
@mattkime
update snapshot
ad3a2b8
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexPatternManagement 606.2KB 606.2KB +6.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 968.9KB 968.9KB +27.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 48ac9f7 into elastic:master Nov 19, 2020
mattkime added a commit to mattkime/kibana that referenced this pull request Nov 19, 2020
@mattkime
[index patterns] Field custom name => custom label (elastic#83717)
77f3c54 
* custom name => custom label
@mattkime mattkime mentioned this pull request Nov 19, 2020
Merged
mattkime added a commit that referenced this pull request Nov 20, 2020
@mattkime
[index patterns] Field custom name => custom label (#83717) (#83867)
a2c3b7e 
* custom name => custom label
@kertal kertal mentioned this pull request Nov 20, 2020
Merged
6 tasks
@nreese nreese mentioned this pull request Mar 23, 2021
Closed
@kertal kertal mentioned this pull request Feb 24, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattkime @elasticmachine @kibanamachine @kertal @streamich