Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code coverage] collect for oss integration tests #83907

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Nov 20, 2020

Summary

Collect code coverage for jest integration tests and merge in jest-combined report

https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/141

Jest combined report stats:

master

44.06% Statements 133066/302004
34.35% Branches 57508/167404
40.64% Functions 33540/82535
51.18% Lines 129181/252424

PR

43.21% Statements 134627/311539
34.63% Branches 58071/167671
39.86% Functions 34102/85555
49.96% Lines 130690/261565

Numbers slightly dropped, but we can see more lines/functions/etc. covered in total 😅

@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Nov 20, 2020
@dmlemeshko
Copy link
Member Author

@elasticmachine merge upstream

@dmlemeshko dmlemeshko added the backport:skip This commit does not require backporting label Nov 24, 2020
@dmlemeshko dmlemeshko marked this pull request as ready for review November 24, 2020 16:25
@dmlemeshko dmlemeshko requested review from a team as code owners November 24, 2020 16:25
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but LGTM

…n.test.ts

Co-authored-by: Spencer <email@spalger.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko merged commit 2634009 into elastic:master Nov 24, 2020
rylnd added a commit to rylnd/kibana that referenced this pull request Nov 24, 2020
* master: (41 commits)
  [Maps] fix code-owners (elastic#84265)
  [@kbn/utils] Clean target before build (elastic#84253)
  [code coverage] collect for oss integration tests (elastic#83907)
  [APM] Use `asTransactionRate` consistently everywhere (elastic#84213)
  Attempt to fix incremental build error (elastic#84152)
  Unskip "Copy dashboards to space" (elastic#84115)
  Remove expressions.legacy from README (elastic#79681)
  Expression: Add render mode and use it for canvas interactivity (elastic#83559)
  [deb/rpm] Move systemd service to /usr/lib/systemd/system (elastic#83571)
  [Security Solution][Resolver] Allow a configurable entity_id field (elastic#81679)
  [ML] Space permision checks for job deletion (elastic#83871)
  [build] Provide ARM build of RE2 (elastic#84163)
  TSVB should use "histogram:maxBars" and "histogram:barTarget" settings for auto instead of a default 100 buckets (elastic#83628)
  [Workplace Search] Initial rendering of Org Sources (elastic#84164)
  update geckodriver to 0.28 (elastic#84085)
  Fix timelion vis escapes single quotes (elastic#84196)
  [Security Solution] Fix incorrect time for dns histogram (elastic#83532)
  [DX] Bump TS version to v4.1 (elastic#83397)
  [Security Solution] Add endpoint policy revision number (elastic#83982)
  [Fleet] Integration Policies List view (elastic#83634)
  ...
@dmlemeshko dmlemeshko deleted the collect-code-coverage-for-jest-integration-tests branch January 31, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants