Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Track code-coverage for maps-plugin folder #83949

Merged
merged 3 commits into from
Nov 23, 2020
Merged

[Maps] Track code-coverage for maps-plugin folder #83949

merged 3 commits into from
Nov 23, 2020

Conversation

thomasneirynck
Copy link
Contributor

Summary

Tracks the map-plugin folder.

@thomasneirynck thomasneirynck added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

kindsun
kindsun approved these changes Nov 21, 2020
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

  • code review

@thomasneirynck
Copy link
Contributor Author

@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 0fd9efd into elastic:master Nov 23, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 25, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 83949 or prevent reminders by adding the backport:skip label.

@thomasneirynck thomasneirynck added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindsun kindsun kindsun approved these changes

@dmlemeshko dmlemeshko Awaiting requested review from dmlemeshko

@nreese nreese Awaiting requested review from nreese

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasneirynck @elasticmachine @kibanamachine @kindsun