Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix advanced settings API integration tests on cloud #84110

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Fix advanced settings API integration tests on cloud #84110

merged 3 commits into from
Nov 24, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Nov 23, 2020

Summary

This PR fixes the advanced settings feature controls API integration tests for cloud and moves some deployment helper methods to a separate service.

Details

Fix advanced settings API integration tests on cloud

Closes #80258

Move helper methods

  • getHostPort, getEsHostPort, isOss and isCloud are moved out of page_objects/common_page into a new common service deployment.
  • The reason for this move is that these methods could also be re-used in API integration tests (particularly the fixed test mentioned above), which is not possible while they are in the (UI test specific) page object.

@pheyos pheyos self-assigned this Nov 23, 2020
@pheyos pheyos marked this pull request as ready for review November 24, 2020 07:00
@pheyos pheyos requested a review from a team as a code owner November 24, 2020 07:00
@pheyos pheyos added the release_note:skip Skip the PR/issue when compiling release notes label Nov 24, 2020
azasypkin
azasypkin approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Code review only, but the changes in Security plugin tests look good.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dmlemeshko
dmlemeshko approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the idea of having deployment service 👏

kertal
kertal approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks for cleaning this up, didn't test!

@pheyos pheyos merged commit a31445f into elastic:master Nov 24, 2020
@pheyos pheyos deleted the fix_advanced_settings_tests_in_cloud branch November 24, 2020 12:46
@pheyos pheyos mentioned this pull request Nov 24, 2020
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Nov 24, 2020
@pheyos
Fix advanced settings API integration tests on cloud (elastic#84110)
ad36a37 
This PR fixes the advanced settings feature controls API integration tests for cloud and moves some deployment helper methods to a separate service.
pheyos added a commit to pheyos/kibana that referenced this pull request Nov 24, 2020
@pheyos
Fix advanced settings API integration tests on cloud (elastic#84110)
de812b4 
This PR fixes the advanced settings feature controls API integration tests for cloud and moves some deployment helper methods to a separate service.
# Conflicts:
#	x-pack/test/functional/page_objects/security_page.ts
#	x-pack/test/security_functional/tests/login_selector/auth_provider_hint.ts
#	x-pack/test/security_functional/tests/login_selector/basic_functionality.ts
@pheyos pheyos mentioned this pull request Nov 24, 2020
Merged
pheyos added a commit that referenced this pull request Nov 24, 2020
@pheyos
Fix advanced settings API integration tests on cloud (#84110) (#84208)
532a9da 
This PR fixes the advanced settings feature controls API integration tests for cloud and moves some deployment helper methods to a separate service.
pheyos added a commit that referenced this pull request Nov 24, 2020
@pheyos
[7.10] Fix advanced settings API integration tests on cloud (#84110) (#…
a042e17 
…84210)

This PR fixes the advanced settings feature controls API integration tests for cloud and moves some deployment helper methods to a separate service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@azasypkin azasypkin azasypkin approved these changes

@kertal kertal kertal approved these changes

Assignees

@pheyos pheyos

Labels
release_note:skip Skip the PR/issue when compiling release notes test_ui_functional test-api-integration v7.10.1 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@pheyos @kibanamachine @kertal @azasypkin @dmlemeshko