Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [DX] Bump TS version to v4.1 (#83397) #84234

Merged
merged 1 commit into from
Nov 24, 2020
Merged

[7.x] [DX] Bump TS version to v4.1 (#83397) #84234

merged 1 commit into from
Nov 24, 2020

Conversation

mshustov
Copy link
Contributor

Backports the following commits to 7.x:

@mshustov
[DX] Bump TS version to v4.1 (elastic#83397)
ae51d1f 
* bump version to 4.1.1-rc

* fix code to run kbn bootstrap

* fix errors

* DO NOT MERGE. mute errors and ping teams to fix them

* Address EuiSelectableProps configuration in discover sidebar

* use explicit type for EuiSelectable

* update to ts v4.1.2

* fix ts error in EuiSelectable

* update docs

* update prettier with ts version support

* Revert "update prettier with ts version support"

This reverts commit 3de48db.

* address another new problem

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
# Conflicts:
#	test/functional/services/remote/remote.ts
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 919.7KB 919.7KB -11.0B
beatsManagement 581.0KB 581.0KB +92.0B
console 982.1KB 982.2KB +99.0B
lens 930.0KB 930.0KB +20.0B
ml 5.2MB 5.2MB +99.0B
searchprofiler 690.7KB 690.8KB +99.0B
security 788.6KB 788.6KB +7.0B
securitySolution 7.9MB 7.9MB +9.0B
snapshotRestore 583.4KB 583.5KB +21.0B
transform 1021.2KB 1021.3KB +99.0B
triggersActionsUi 1.5MB 1.5MB +99.0B
watcher 955.4KB 955.5KB +99.0B
total +732.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 188.3KB 188.3KB +9.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit e77769a into elastic:7.x Nov 24, 2020
@mshustov mshustov deleted the backport/7.x/pr-83397 branch November 24, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshustov @kibanamachine