[APM] Rename ChartsSyncContext to PointerEventContext
#84272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
added
release_note:skip
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
sorenlouv
deleted the
rename-chart-sync-context-to-pointer-event-context
branch
sorenlouv
added a commit
that referenced
this pull request
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChartsSyncContextwas a terrible name to begin with. It's vague without being general in a good way. The risk is that the context can become a kitchen sink of anything that seem remotely related to charts (see: God object)Solution: change the naming to match exactly what the context does and it will be much more difficult to squeeze extra things in there.
PointerEventContextmakes it clear that this context allows the consumer to retrieve and set a shared pointer event between charts. Nothing more, nothing less.