[Task Manager] Skip removed task types when claiming tasks #84273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
changed the title
ymao1
added
Feature:Task Manager
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
gmmorris
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
LGTM, looks like it's working as expected. :)
My two notes though are:
- Can we reduce the size of
mappings.json? - Is it worth marking the removed tasks as
failed(or even a new status?)? otherwise they'll remain in 'idle` forever. This isn't a must, but seems like a nice tweak while we're in here.
x-pack/test/functional/es_archives/task_manager_removed_types/mappings.json
Show resolved
Hide resolved
…manager/removed-types
…manager/removed-types
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Dec 2, 2020
…4273) * Checking if task type is in registered list * Loading esArchiver data with removed task type for testing * PR fixes
ymao1
added a commit
that referenced
this pull request
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #84088
Summary
Adds a check in the update by query painless script to ensure the task type is in the list of currently registered task types to ensure we're only trying to claim (or mark as failed) current task types.
Checklist
Delete any items that are not applicable to this PR.