Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UsageCollection] Remove formatBulkUpload and other unused APIs #84313

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

afharo
Copy link
Member

@afharo afharo commented Nov 25, 2020

Summary

After #83546 was completed, we can remove many of the APIs the plugin UsageCollection was exposing specifically for bulk_uploader to use it.

One of the key changes is formatForBulkUpload is removed and its types.

Closes #83521

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@afharo afharo added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 25, 2020
@afharo afharo marked this pull request as ready for review November 25, 2020 12:32
@afharo afharo requested review from a team as code owners November 25, 2020 12:32
@afharo afharo requested a review from a team November 25, 2020 12:32
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces changes LGTM!

@afharo
Copy link
Member Author

afharo commented Nov 30, 2020

@elasticmachine merge upstream

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit cb55898 into elastic:master Nov 30, 2020
@afharo afharo deleted the usageCollection/remove-unused-apis branch November 30, 2020 11:30
afharo added a commit to afharo/kibana that referenced this pull request Nov 30, 2020
…astic#84313)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
afharo added a commit that referenced this pull request Nov 30, 2020
…Is (#84313) (#84489)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 30, 2020
…bana into add-metadata-to-node-details

* 'add-metadata-to-node-details' of github.com:phillipb/kibana:
  [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended  (elastic#84415)
  Support for painless language autocomplete within monaco (elastic#80577)
  [Lens] Time scale ui (elastic#83904)
  removing beta callouts (elastic#84510)
  [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493)
  Trusted Apps signer API. (elastic#83661)
  increase stdout max listeners for legacy logging (elastic#84497)
  [APM] Service overview: Add throughput chart (elastic#84439)
  [Discover] Unskip main functional tests (elastic#84300)
  Uptime overview overhaul (elastic#83406)
  [APM] Adjust time formats based on the difference between start and end (elastic#84470)
  [ML] Renaming saved object repair to sync (elastic#84311)
  [UsageCollection] Remove `formatBulkUpload` and other unused APIs (elastic#84313)
  [Visualizations] Adds visConfig.title and uiState to build pipeline function (elastic#84456)
  [Elasticsearch Migration] Update docs re UsageCollection (elastic#84322)
  TSVB field list performance issue on using annotations (elastic#84407)
  [Security Solution] Exceptions Cypress tests (elastic#81759)
  [ML] Fix spaces job ID check (elastic#84404)
  [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry/Monitoring] Monitoring should stop collecting Kibana Usage in the .monitoring indices
5 participants