Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test user assignment to embeddable maps tests #84383

Merged
merged 10 commits into from
Dec 2, 2020
Merged

Test user assignment to embeddable maps tests #84383

merged 10 commits into from
Dec 2, 2020

Conversation

bhavyarm
Copy link
Contributor

This PR adds test_user to maps tests under embeddable folder.
Also added in this bug - #84382

@bhavyarm bhavyarm self-assigned this Nov 25, 2020
@bhavyarm bhavyarm added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation test_xpack_functional v8.0.0 v7.11.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 25, 2020
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Dec 1, 2020

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Dec 1, 2020

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Dec 1, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm bhavyarm marked this pull request as ready for review December 1, 2020 20:47
@bhavyarm bhavyarm requested a review from a team as a code owner December 1, 2020 20:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@bhavyarm bhavyarm requested a review from LeeDr December 1, 2020 20:48
kindsun
kindsun approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

  • code review

LeeDr
LeeDr approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I code reviewed and checked Jenkins CI results - all good
Test Result : x-pack/test/functional/apps/maps/embeddable/dashboard·js

@bhavyarm bhavyarm merged commit d481adc into elastic:master Dec 2, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 4, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 84383 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 84383 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 84383 or prevent reminders by adding the backport:skip label.

@bhavyarm bhavyarm mentioned this pull request Dec 8, 2020
Merged
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Dec 8, 2020
@bhavyarm
Test user assignment to embeddable maps tests (elastic#84383)
31e019b
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 8, 2020
bhavyarm added a commit that referenced this pull request Dec 8, 2020
@bhavyarm
Test user assignment to embeddable maps tests (#84383) (#85307)
7d9e916
@bhavyarm bhavyarm mentioned this pull request Feb 5, 2021
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindsun kindsun kindsun approved these changes

@LeeDr LeeDr LeeDr approved these changes

Assignees

@bhavyarm bhavyarm

Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavyarm @kibanamachine @elasticmachine @kindsun @LeeDr