Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expected table headers to fix functional test #8479

Merged
merged 1 commit into from
Sep 30, 2016

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Sep 26, 2016

@thomasneirynck thomasneirynck self-assigned this Sep 27, 2016
@thomasneirynck
Copy link
Contributor

LGTM

@epixa
Copy link
Contributor

epixa commented Sep 28, 2016

@Bargs Let's get this sorted today to get the tests green again

@Bargs
Copy link
Contributor Author

Bargs commented Sep 29, 2016

jenkins, test this

@Bargs
Copy link
Contributor Author

Bargs commented Sep 29, 2016

tests pass locally, trying to re-run them but I'm not sure if Jenkins test this runs the selenium tests

@Bargs
Copy link
Contributor Author

Bargs commented Sep 29, 2016

Ah I see now, there's more than one test failure, but for some reason the second one wasn't showing up with fail: in the logs. For some reason the geo.coordinates field isn't available in the tilemap test. This could be a legitimate bug. I'm about to hop on a plane, I'll try to look at it later but if anyone else has a moment to check it out, they might be able to get to it before I do.

@spalger spalger merged commit f65c9b5 into elastic:master Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants