Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Clean all packages before the builds #84938

Closed
wants to merge 9 commits into from

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Dec 3, 2020

We are still recieving reports of issues with builds after updates to a local branch. I have gone through all our packages to ensure they are all now clearning the target.

Related to #84253

Examples of errors:

 info [kibana] running [kbn:bootstrap] script
ERROR [bootstrap] failed:
ERROR Error: Command failed with exit code 1: C:\Users\LeeDr\.yarn\bin\yarn.js run kbn:bootstrap
      error Command failed with exit code 1.
      $ node scripts/build_ts_refs && node scripts/register_git_hook
      ERROR Error: Command failed with exit code 1: C:\Users\LeeDr\git\kibana\node_modules\typescript\bin\tsc -b tsconfig.refs.json --pret
ty
            src/plugins/kibana_react/target/types/public/table_list_view/table_list_view.d.ts:55:38 - error TS2694: Namespace '_' has no e
xported member 'DebouncedFunc'.
            55     debouncedFetch: import("lodash").DebouncedFunc<(filter: string) => Promise<void>>;
                                                    ~~~~~~~~~~~~~
            src/plugins/kibana_react/target/types/public/table_list_view/table_list_view.d.ts:55:38 - error TS2694: Namespace '_' has no e
xported member 'DebouncedFunc'.
            55     debouncedFetch: import("lodash").DebouncedFunc<(filter: string) => Promise<void>>;
                                                    ~~~~~~~~~~~~~
            Found 2 errors.
                at makeError (C:\Users\LeeDr\git\kibana\node_modules\execa\lib\error.js:59:11)
                at handlePromise (C:\Users\LeeDr\git\kibana\node_modules\execa\index.js:114:26)
                at processTicksAndRejections (internal/process/task_queues.js:93:5)
                at buildRefs (C:\Users\LeeDr\git\kibana\src\dev\typescript\/build_refs.ts:32:5)
                at buildAllRefs (C:\Users\LeeDr\git\kibana\src\dev\typescript\/build_refs.ts:25:3)
                at description (C:\Users\LeeDr\git\kibana\src\dev\typescript\/build_refs.ts:42:7)
                at C:\Users\LeeDr\git\kibana\packages\kbn-dev-utils\target\run\run.js:54:13
                at Object.withProcRunner (C:\Users\LeeDr\git\kibana\packages\kbn-dev-utils\target\proc_runner\with_proc_runner.js:35:9)
                at run (C:\Users\LeeDr\git\kibana\packages\kbn-dev-utils\target\run\run.js:53:9)
      error Command failed with exit code 1.
      $ node scripts/build --source-maps
       info Deleting old output
       info Starting babel and typescript
       info [babel     ] > babel src --config-file C:\Users\mariu\Documents\GitHub\kibana\packages\kbn-test\babel.config.js --out-dir C:\Users\mariu\Documents\GitHub\kibana\packages\kbn-test\targ
et --extensions .ts,.js,.tsx --quiet --source-maps inline
       info [tsc       ] > tsc --declarationMap true
       info [babel     ] exited with 0 after a few seconds
       proc [tsc       ] src/functional_test_runner/lib/snapshots/decorate_snapshot_ui.ts(199,7): error TS2578: Unused '@ts-expect-error' directive.
      ERROR UNHANDLED ERROR
ERROR [bootstrap] failed:
ERROR Error: Command failed with exit code 2: /usr/share/yarn/bin/yarn.js run kbn:bootstrap
      error Command failed with exit code 2.
      error Command failed with exit code 2.
      $ yarn build
      $ tsc
      src/log_format_json.test.ts(23,10): error TS2305: Module '"../../../node_modules/@kbn/utils/target"' has no exported member 'createListStream'.
      src/log_format_json.test.ts(23,28): error TS2305: Module '"../../../node_modules/@kbn/utils/target"' has no exported member 'createPromiseFromStreams'.
      src/log_format_string.test.ts(23,10): error TS2305: Module '"../../../node_modules/@kbn/utils/target"' has no exported member 'createListStream'.
      src/log_format_string.test.ts(23,28): error TS2305: Module '"../../../node_modules/@kbn/utils/target"' has no exported member 'createPromiseFromStreams'.
      info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
      info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
          at makeError (/home/lizozom/Projects/kibana/packages/kbn-pm/dist/index.js:35145:11)
          at handlePromise (/home/lizozom/Projects/kibana/packages/kbn-pm/dist/index.js:34057:26)
          at processTicksAndRejections (internal/process/task_queues.js:97:5)
          at async /home/lizozom/Projects/kibana/packages/kbn-pm/dist/index.js:9058:9
          at async scheduleItem (/home/lizozom/Projects/kibana/packages/kbn-pm/dist/index.js:22753:9)
error Command failed with exit code 1.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 3, 2020
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small thing: as you are cleaning rm -rf maybe you also want to clean the one we are using at. https://github.com/elastic/kibana/blob/master/package.json#L66 ?

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic
Copy link
Member

mistic commented Dec 14, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Dec 28, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Jan 4, 2021

@elasticmachine merge upstream

kibanamachine and others added 2 commits January 4, 2021 14:09
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 48005 47998 -7
oss 27713 27706 -7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants