Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix functional test failures #84979

Merged
merged 4 commits into from
Dec 7, 2020

Conversation

wylieconlon
Copy link
Contributor

@wylieconlon wylieconlon commented Dec 4, 2020

Two tests started failing to close the dimension editor panel. I believe that there is an issue successfully clicking icon buttons, which was a change that @mbondyra recently made to keep it accessible. The retry now verifies that the panel closes.

Fixes #84941, Fixes #84957, Fixes #84978

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.11.0 labels Dec 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

I'm not sure how this is improving the situation - looks like it is retrying the click if it failed but I don't think the close click is failing, it's the flyout re-rendering too slowly. So the click works and react re-renders but by the time the test tries to click the next element, the flyout is still open and the next element is shadowed.

I suggest clicking the close button, then waiting for it to disappear (and optionally wrapping that into a retry)

@wylieconlon
Copy link
Contributor Author

@flash1293 Yes, that approach is what I'm doing now. This now waits to verify that the panel has closed.

I also removed the field cache from the rollup index pattern.

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, will merge on green build

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 46902 47662 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 2466dd6 into elastic:master Dec 7, 2020
flash1293 pushed a commit to flash1293/kibana that referenced this pull request Dec 7, 2020
@wylieconlon wylieconlon deleted the lens/fix-functional branch December 14, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment