Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search Source] Do not pick scripted fields if * provided #85133

Merged
merged 5 commits into from
Dec 9, 2020
Merged

[Search Source] Do not pick scripted fields if * provided #85133

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
305934e
[Search Source] Do not pick scripted fields if * provided
Dec 7, 2020
d1cf97e
Update src/plugins/data/common/search/search_source/search_source.ts
Dec 7, 2020
c955838
Merge branch 'master' into pr/85133
timroes Dec 8, 2020
89db41a
Add unit test
timroes Dec 8, 2020
ff828f3
Add documentation
timroes Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/plugins/data/common/search/search_source/search_source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,11 +518,13 @@ export class SearchSource {
);
const uniqFieldNames = [...new Set([...bodyFieldNames, ...fieldsFromSource])];

// filter down script_fields to only include items specified
body.script_fields = pick(
body.script_fields,
Object.keys(body.script_fields).filter((f) => uniqFieldNames.includes(f))
);
if (uniqFieldNames.indexOf('*') === -1) {
majagrubic marked this conversation as resolved.
Show resolved Hide resolved
// filter down script_fields to only include items specified
body.script_fields = pick(
body.script_fields,
Object.keys(body.script_fields).filter((f) => uniqFieldNames.includes(f))
);
}

// request the remaining fields from stored_fields just in case, since the
// fields API does not handle stored fields
Expand Down