[7.x] [ILM] Add searchable snapshot field (#83783) #85138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added server-side endpoint for getting list of repos * part one of client side changes: added searchable snapshot field - added to both hot and cold - serializing into JSON payload * make searchable snapshot field toggleable and require value when it is being used * fix typo in file name and remove whitespace * added searchable snapshot state context, wip * finished updating fields to show and hide based on searchable snapshot in the hot phase * hiding fields when searchable snapshots is enabled in hot - removed nested EuiFieldRow components in data allocation field - added SCSS files for data allocation field and searchable snapshot field * added translations and a first hot phase serialization test * appease type check and i18n * added cloud-specific behaviour for searchable snapshot default inlc. test * refactor snapshot state -> configuration issues as this a can be re-used for other issues * added configuration context file * hide replicas in cold if snapshotting * updated new field copy * update test coverage, test for hiding certain fields too * added license check to client side! * moved warning to below field again and moved hot phase searchable snapshot notice to right * make described form field lazy if needed * render field even when license requirement is not met * update serializer for removing searchable_snapshot field * handle 404 from ES when looking up * snapshot repos - we return an empty array * address license TODO * added tests for license check and removed license check HoC * fix legacy jest tests * added readme about legacy tests * updated jest tests and fix type issues * remove unused import * refactor component names to have "Field" at the end * refactor searchable snapshot to single interface def and add comment about force_merge_index option * address stakeholder feebdack and pr comments * update tests after latest changes * link to force merge * Revert "link to force merge" This reverts commit 6c714fb. * introduce advanced section to hot, warm and cold * added test for correctly deserializing delete phase, and added fix * remove unused variable * moved fields into advanced settings * move learn more copy below enable toggle * fix warm phase on rollover default * remove label space above rollover toggle * remove unused import * update test after fixing warm on rollover default * removed icons in callouts in searchable snapshot field, added ability to control field toggles * move callouts to description text * readd warning callouts to the searchable snapshot field * slight i18n adjustment * made callout for actions disabled a bit smaller * fix i18n Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
Page load bundle
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: