Update config usage from geoAlerts -> geoAlerting #85220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindsun
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
💚 Build SucceededMetrics [docs]Distributable file count
Page load bundle
To update your PR or re-run it, just comment with: |
thomasneirynck
approved these changes
Dec 9, 2020
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Dec 9, 2020
kindsun
pushed a commit
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#84151 introduced the config value
geoAlerts. Upon further thought, I think it would make sense to name it more generically togeoAlerting. This name gives us some flexibility to have it reference single or multiple geo alerting capabilities which may be relevant if we add, remove or consolidate alerts moving forward. Also much easier to knock this out earlier rather than later having to ask users/testers to update their configs multiple times.