Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Better disabled messages for Value labels popup #85592

Merged
merged 3 commits into from
Dec 14, 2020
Merged

[Lens] Better disabled messages for Value labels popup #85592

merged 3 commits into from
Dec 14, 2020

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Dec 10, 2020

Summary

Fixes #83252

Better disabled reason message for value labels popup menu, covering the stacked bar scenario as well.

Screenshot 2020-12-10 at 16 01 39

Screenshot 2020-12-10 at 16 01 50

Screenshot 2020-12-10 at 16 01 57

Screenshot 2020-12-10 at 16 02 39

Checklist

Delete any items that are not applicable to this PR.

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.11.0 labels Dec 10, 2020
@dej611 dej611 requested a review from a team December 10, 2020 15:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dej611
Copy link
Contributor Author

dej611 commented Dec 14, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1012.6KB 1013.1KB +504.0B

Distributable file count

id before after diff
default 47129 47889 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. This is not perfect because on a stacked bar histogram vis, it won't give you the full reason why you can't edit it. But IMHO that's fine, we shouldn't overcomplicate this logic.

@dej611 dej611 merged commit 1ff2331 into elastic:master Dec 14, 2020
@dej611 dej611 deleted the fix/83252 branch December 14, 2020 14:23
@dej611 dej611 mentioned this pull request Dec 15, 2020
Merged
dej611 added a commit that referenced this pull request Dec 16, 2020
@dej611 @kibanamachine
[7.x] [Lens] Better disabled messages for Value labels popup (#85592) (…
64ab395 
…#85949)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] misleading message for disabling values on chart for categorical x-Axis
4 participants
@dej611 @elasticmachine @kibanamachine @flash1293