Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drilldown allow list #85740

Closed
wants to merge 72 commits into from
Closed

Drilldown allow list #85740

wants to merge 72 commits into from

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Dec 14, 2020

Summary

Closes #69412

See Release note below for more info.

Checklist

Delete any items that are not applicable to this PR.

For maintainers


Release note

ExternalUrl service was integrated with URL Drilldown. This will check every URL Drilldown before executing it against ExternalUrl service to see if user is allowed to navigate to that external URL. By default all external URLs are allowed. To configure external URL policies you need to use externalUrl.policy setting in kibana.yml, an example:

externalUrl.policy:
  - allow: false
    host: danger.google.com
  - allow: true
    host: google.com
    protocol: https
  - allow: true
    host: elastic.co

@streamich streamich requested a review from a team December 14, 2020 09:58
@streamich streamich requested review from a team as code owners December 14, 2020 09:58
@botelastic botelastic bot added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) labels Dec 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@streamich streamich added Feature:UIActions UI actions. These are client side only, not related to the server side actions.. and removed Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) labels Dec 14, 2020
@streamich streamich closed this Dec 14, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47129 47889 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
urlDrilldown 50.6KB 51.2KB +587.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Drilldowns Embeddable panel Drilldowns Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:enhancement v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL drilldown allow list
3 participants