Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SO Tagging] Update tag delete modal confirmation title #85997

Merged
merged 2 commits into from
Dec 15, 2020
Merged

[SO Tagging] Update tag delete modal confirmation title #85997

merged 2 commits into from
Dec 15, 2020

Conversation

pgayvallet
Copy link
Contributor

Remove the 'are you sure' part to respect our guidelines

cc @gchaps

@pgayvallet pgayvallet marked this pull request as ready for review December 15, 2020 18:26
@pgayvallet pgayvallet requested a review from a team as a code owner December 15, 2020 18:26
@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 v8.0.0 labels Dec 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

MichaelMarcialis
MichaelMarcialis approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @pgayvallet.

TinaHeiligers
TinaHeiligers approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
savedObjectsTagging 115.6KB 115.6KB -74.0B

Distributable file count

id before after diff
default 47132 47892 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit a4c4fe0 into elastic:master Dec 15, 2020
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Dec 15, 2020
@pgayvallet
[SO Tagging] Update tag delete modal confirmation title (elastic#85997)
9ff64e6 
* Update tag deletion modal confirmation text

* add .
@pgayvallet pgayvallet mentioned this pull request Dec 15, 2020
Merged
pgayvallet added a commit that referenced this pull request Dec 16, 2020
@pgayvallet
[SO Tagging] Update tag delete modal confirmation title (#85997) (#86022
05bad3d 
)

* Update tag deletion modal confirmation text

* add .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pgayvallet @elasticmachine @kibanamachine @MichaelMarcialis @TinaHeiligers