Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates elasticsearch client in the kibana_usage_collector #86406

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Migrates elasticsearch client in the kibana_usage_collector #86406

merged 2 commits into from
Dec 18, 2020

Conversation

TinaHeiligers
Copy link
Contributor

Summary

Uses the new elasticsearch client in the kibana_usage_collector.
Part of #86358

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Dec 17, 2020
@TinaHeiligers TinaHeiligers requested a review from afharo December 17, 2020 23:36
afharo
afharo approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this Tina! 🧡
I added a few NITs and one comment to a test that I think we changed the intended response from ES.
I've also tested the changes. It LGTM, and can be merged once the comments are taken care of!

src/plugins/kibana_usage_collection/server/collectors/kibana/get_saved_object_counts.test.ts Outdated Show resolved Hide resolved
src/plugins/kibana_usage_collection/server/collectors/kibana/get_saved_object_counts.test.ts Outdated Show resolved Hide resolved
src/plugins/kibana_usage_collection/server/collectors/kibana/get_saved_object_counts.test.ts Show resolved Hide resolved
src/plugins/kibana_usage_collection/server/collectors/kibana/get_saved_object_counts.test.ts Outdated Show resolved Hide resolved
@TinaHeiligers TinaHeiligers marked this pull request as ready for review December 18, 2020 15:42
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner December 18, 2020 15:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers
Copy link
Contributor Author

@afharo I don't know why your LGTM didn't trigger for a review for the core-team. Maybe it's because I changed the PR status? Would you mind trying to LGTM again please?

@afharo
Copy link
Member

afharo commented Dec 18, 2020

I guess I got kicked out of the team for a minute 😅! Done!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit 6a51741 into elastic:master Dec 18, 2020
@TinaHeiligers TinaHeiligers deleted the migrate-kibana-usage-collector-es-client branch December 18, 2020 17:55
@TinaHeiligers TinaHeiligers mentioned this pull request Dec 18, 2020
Merged
TinaHeiligers added a commit to TinaHeiligers/kibana that referenced this pull request Dec 18, 2020
@TinaHeiligers
Migrates elasticsearch client in the kibana_usage_collector (elastic#…
9a01598 
…86406)
TinaHeiligers added a commit that referenced this pull request Dec 18, 2020
@TinaHeiligers
[7.x] Migrates elasticsearch client in the kibana_usage_collector (#8…
46dceb9 
…6406) (#86494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TinaHeiligers @elasticmachine @afharo @kibanamachine