-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] JSON view for data is not displayed properly #87008
Conversation
@elasticmachine merge upstream |
height: 100%; | ||
`; | ||
const TabListHeight = 48; | ||
const StyledEuiFlexItem = styled(EuiFlexItem)<{ $tabListHeight?: number; $messageHeight?: number }>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we try to achieve the same just with the css? using ref can have impact on the performance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested on chrome, firefox, safari, and ms edge.
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
…stic#87008) # Conflicts: # x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx
…stic#87008) # Conflicts: # x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx
) (#87330) # Conflicts: # x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
#87008) (#87329) * [Security Solution] JSON view for data is not displayed properly (#87008) # Conflicts: # x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx * Update event_details.test.tsx Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
Summary
The content of Json viewer in Alert details / Event details is chopped because of styling problem.
More Description and steps to reproduce:
#86098