Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] JSON view for data is not displayed properly #87008

Merged
merged 9 commits into from
Jan 5, 2021

Conversation

angorayc
Copy link
Contributor

Summary

The content of Json viewer in Alert details / Event details is chopped because of styling problem.
More Description and steps to reproduce:
#86098

Screenshot 2020-12-30 at 03 12 32

@angorayc angorayc added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Dec 29, 2020
@angorayc angorayc requested review from a team as code owners December 29, 2020 19:14
@patrykkopycinski
Copy link
Contributor

image
seems it still doesn't take the whole available space

@angorayc
Copy link
Contributor Author

angorayc commented Jan 4, 2021

@elasticmachine merge upstream

height: 100%;
`;
const TabListHeight = 48;
const StyledEuiFlexItem = styled(EuiFlexItem)<{ $tabListHeight?: number; $messageHeight?: number }>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we try to achieve the same just with the css? using ref can have impact on the performance

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on chrome, firefox, safari, and ms edge.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +1.2KB

Distributable file count

id before after diff
default 47252 48012 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 81887b7 into elastic:master Jan 5, 2021
@patrykkopycinski patrykkopycinski deleted the issue-86098 branch January 5, 2021 16:07
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Jan 5, 2021
…stic#87008)

# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Jan 5, 2021
…stic#87008)

# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx
patrykkopycinski added a commit that referenced this pull request Jan 5, 2021
) (#87330)

# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
patrykkopycinski added a commit that referenced this pull request Jan 5, 2021
#87008) (#87329)

* [Security Solution] JSON view for data is not displayed properly (#87008)

# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx

* Update event_details.test.tsx

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
@oatkiller oatkiller added the Feature:Timeline Security Solution Timeline feature label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Timeline Security Solution Timeline feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants