Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use doc links service for Dashboard and Discover help links #87224

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 4, 2021

Summary

This PR updates the help menu links for Discover and Dashboard apps such that they use links from the doc link service, which are easier to maintain.

@lcawl lcawl added Feature:Dashboard Dashboard related features Feature:Discover Discover Application v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 4, 2021
@lcawl lcawl requested a review from gchaps January 4, 2021 20:38
@lcawl lcawl marked this pull request as ready for review January 4, 2021 22:49
@lcawl lcawl requested a review from a team January 4, 2021 22:49
@lcawl lcawl requested review from a team as code owners January 4, 2021 22:49
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM.

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 197.8KB 197.7KB -69.0B
discover 502.3KB 502.2KB -69.0B
total -138.0B

Distributable file count

id before after diff
default 47252 48012 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 564.0KB 564.1KB +109.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants