-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search][Discover] Send to background integration improvements and fixes #87311
[Search][Discover] Send to background integration improvements and fixes #87311
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM, but please consider adding a timestamp to the session name.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
ACK, will review |
…scover-restore-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, was testing linking back via the management UI when you're using a saved search the link is correct, but there seems to be an error restoring the session, I think this is unrelated to this PR, so I'm approving this, maybe you could check before merging. many thx for the refactoring and adding tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested locally, works with absolute time ranges, finally approving this, not pretending to do so :)
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Closes #87148
This pr makes couple improves to send to background integration in Discover:
Discover
(Unfortunately to properly tests needs [Data/Search Sessions] Management UI #81707. Also can be tested by inspecting network request that saves a session)Checklist