Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): move console out of __tests__ folder #87368

Merged
merged 1 commit into from
Jan 6, 2021
Merged

chore(NA): move console out of __tests__ folder #87368

merged 1 commit into from
Jan 6, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Jan 5, 2021

It moves the second item of #85513 as it moves console out of tests folder into our common setup for tests run with jest.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.11.1 labels Jan 5, 2021
@mistic mistic requested a review from tylersmalley January 5, 2021 18:12
@mistic mistic requested a review from a team as a code owner January 5, 2021 18:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

tylersmalley
tylersmalley approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I don't believe the files in the tests directories were even running for Console.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47252 48014 +762
oss 27713 27715 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Jan 6, 2021

@elastic/es-ui can I have your review here please?

alisonelizabeth
alisonelizabeth approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks @mistic!

@mistic mistic merged commit 14fde6d into elastic:master Jan 6, 2021
@mistic
Copy link
Member Author

mistic commented Jan 6, 2021 •
edited
Loading

7.x/7.12: 3ec9607
7.11/7.11.1: 38a566f

@mistic mistic mentioned this pull request Jan 6, 2021
Merged
mistic added a commit to mistic/kibana that referenced this pull request Jan 6, 2021
@mistic
chore(NA): move console out of __tests__ folder (elastic#87368)
0c034a2
mistic added a commit to mistic/kibana that referenced this pull request Jan 6, 2021
@mistic
chore(NA): move console out of __tests__ folder (elastic#87368)
71a6264
@mistic mistic mentioned this pull request Jan 6, 2021
Merged
mistic added a commit that referenced this pull request Jan 6, 2021
@mistic
chore(NA): move console out of __tests__ folder (#87368) (#87526)
38a566f
mistic added a commit that referenced this pull request Jan 6, 2021
@mistic @kibanamachine
chore(NA): move console out of __tests__ folder (#87368) (#87525)
3ec9607 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.1 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @kibanamachine @tylersmalley @alisonelizabeth