Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task Manager] adds more granular polling results to monitoring stats #87494

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

gmmorris
Copy link
Contributor

@gmmorris gmmorris commented Jan 6, 2021

Summary

Added the following values to the Polling stats:

  • NoAvailableWorkers: This tells us when a polling cycle resulted in no tasks being claimed due to there being no available workers
  • RunningAtCapacity: This tells us when a polling cycle resulted in tasks being claimed at 100% capacity of the available workers
  • Failed: This tells us when the poller failed to claim

Adding these to aid with #40264

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47262 48025 +763

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and looks very clear! To which issue this changes related?

@gmmorris
Copy link
Contributor Author

gmmorris commented Jan 6, 2021

Code LGTM and looks very clear! To which issue this changes related?

Thanks Yul, it's something I'm adding because of the ongoing perf tests, but it doesn't resolve any issue.
Adding a comment up top.

@gmmorris gmmorris marked this pull request as ready for review January 6, 2021 17:59
@gmmorris gmmorris requested a review from a team as a code owner January 6, 2021 17:59
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmmorris gmmorris merged commit e0db4a3 into elastic:master Jan 6, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 6, 2021
…elastic#87494)

Added the following values to the Polling stats:

- **NoAvailableWorkers**: This tells us when a polling cycle resulted in no tasks being claimed due to there being no available workers 
- **RunningAtCapacity**: This tells us when a polling cycle resulted in tasks being claimed at 100% capacity of the available workers
- **Failed**: This tells us when the poller failed to claim
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 6, 2021
…elastic#87494)

Added the following values to the Polling stats:

- **NoAvailableWorkers**: This tells us when a polling cycle resulted in no tasks being claimed due to there being no available workers 
- **RunningAtCapacity**: This tells us when a polling cycle resulted in tasks being claimed at 100% capacity of the available workers
- **Failed**: This tells us when the poller failed to claim
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmmorris added a commit that referenced this pull request Jan 6, 2021
…#87494) (#87539)

Added the following values to the Polling stats:

- **NoAvailableWorkers**: This tells us when a polling cycle resulted in no tasks being claimed due to there being no available workers 
- **RunningAtCapacity**: This tells us when a polling cycle resulted in tasks being claimed at 100% capacity of the available workers
- **Failed**: This tells us when the poller failed to claim
gmmorris added a commit that referenced this pull request Jan 6, 2021
…#87494) (#87540)

Added the following values to the Polling stats:

- **NoAvailableWorkers**: This tells us when a polling cycle resulted in no tasks being claimed due to there being no available workers 
- **RunningAtCapacity**: This tells us when a polling cycle resulted in tasks being claimed at 100% capacity of the available workers
- **Failed**: This tells us when the poller failed to claim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants