[ILM] Prettify JSON in "Show request" flyout #87612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
chore
Feature:ILM
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
yuliacech
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
thanks for fixing on this @jloleysens ! changes LGTM and confirmed the fix locally as well 👍
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 11, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 11, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens
added a commit
that referenced
this pull request
Jan 11, 2021
jloleysens
added a commit
that referenced
this pull request
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the JS spec an object
{}contains unordered keys (i.e., the order of the keys should not be relied upon) - see this StackOverflow post that references the ECMAScript spec.However, "normal" keys are generally ordered by insertion order. This PR adds a prettify step to the JSON that is displayed in the flyout to order phases in the policy payload by phase order rather than the order in which the object is assembled in the form lib.
Unordered, pre this PR (hot, delete, cold warm)
Ordered, after the changes are applied (hot, warm, cold, delete)
Notes
This does not order the actions in phases, but ordering the phases is at least a large improvement.