Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Charts: Define placement “Right” to offset tooltip #87729

Merged
merged 2 commits into from
Jan 11, 2021
Merged

[APM] Charts: Define placement “Right” to offset tooltip #87729

merged 2 commits into from
Jan 11, 2021

Conversation

formgeist
Copy link
Contributor

@formgeist formgeist commented Jan 7, 2021

Summary

Initially reported to Elastic Charts as a bug (elastic/elastic-charts#966), but we simply need to set the placement differently to offset the tooltip on external charts when using the tooltip synchronization.

Before

image

After

Kapture.2021-01-07.at.21.01.09.mp4

Screenshot 2021-01-07 at 21 01 21

@formgeist formgeist added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Jan 7, 2021
@formgeist formgeist requested a review from a team as a code owner January 7, 2021 20:06
@formgeist formgeist self-assigned this Jan 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @formgeist!

@formgeist
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB -1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@formgeist formgeist merged commit c545b32 into elastic:master Jan 11, 2021
@formgeist formgeist deleted the apm-charts-fix-external-tooltip-placement branch January 11, 2021 10:00
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 11, 2021
* master:
  [APM] Define placement “Right” to offset tooltip (elastic#87729)
  Fix UI glitch on SOM delete confirmation modal (elastic#87623)
  Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies (elastic#86988)
  [Timelion] Fix tests flakiness on suggestion click (elastic#87273)
  [Uptime] Fix/details page tabs (elastic#86296)
  [ML] Fix earliest and latest texts for date fields (elastic#87482)
  chore(NA): move grokdebugger plugin test fixtures out of __tests__ folder (elastic#87765)
  [Security Solution] Refactor Cypress scenarios to use internal contex… (elastic#86609)
  [Security Solution] Unskip cypress tests (elastic#86653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants