Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code coverage] do not collect stats for mocha #87859

Merged
merged 1 commit into from
Jan 11, 2021
Merged

[code coverage] do not collect stats for mocha #87859

merged 1 commit into from
Jan 11, 2021

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Jan 11, 2021 •
edited
Loading

Summary

Mocha runner returns no tests, so it looks like all tests are migrated to Jest runner. We don't need to collect mocha coverage anymore.

Code coverage pipeline tested

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko marked this pull request as ready for review January 11, 2021 18:11
@dmlemeshko dmlemeshko requested a review from a team as a code owner January 11, 2021 18:11
@dmlemeshko dmlemeshko added code coverage Issues & PRs about code coverage v8.0.0 backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Jan 11, 2021
wayneseymour
wayneseymour reviewed Jan 11, 2021
View reviewed changes
vars/kibanaCoverage.groovy
@@ -78,7 +77,6 @@ def prokLinks(title) {
kibanaPipeline.bash('''
cat << EOF > src/dev/code_coverage/www/index_partial_2.html
<a class="nav-link" href="https://kibana-coverage.elastic.dev/${TIME_STAMP}/jest-combined/index.html">Latest Jest</a>
<a class="nav-link" href="https://kibana-coverage.elastic.dev/${TIME_STAMP}/mocha-combined/index.html">Latest Mocha</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I forgot about this!

wayneseymour
wayneseymour approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko merged commit b10be9e into elastic:master Jan 11, 2021
@dmlemeshko dmlemeshko deleted the remove-mocha-coverage branch January 31, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wayneseymour wayneseymour wayneseymour approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting code coverage Issues & PRs about code coverage release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmlemeshko @kibanamachine @tylersmalley @wayneseymour