[Search Session] Fix integration in vega, timelion and TSVB #87862

Dosant · 2021-01-11T16:00:11Z

Summary

This pr address some search session integration issues in vega, timelion, and TSVB panels.

Part of #61738
Follow up on #82835, #82232, #82229

Similar to visualize/lens integration pass local sessionId received from expression pipeline instead of getting it from global data service
Because timelion and TSVB don't use client-side data service:
- Pass isRestore and isStored boolean flags to the server
- Call trackSearch/untrackSearch on a session

How to test

In kibana.yml:

xpack.data_enhanced.search.sendToBackground.enabled: true

Create a dashboard with vega, timelion, and TSVB panels. Use absolute time range.
Save the session.
Get a session id from an inspector or network request. Append it to your dashboard URL: dashboardUrl&searchSessionId={your-id}
Use this URL, all panels should be loaded and the session indicator should be in "restored" state.

to make sure we are actually restoring data for all the panels try augmenting the dashboard state in the URL, e.g. changing time, or use a fake session id in the URL. All panels should fail.

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-01-11T21:16:58Z

Pinging @elastic/kibana-app-services (Team:AppServices)

alexwizp · 2021-01-12T07:13:14Z

src/plugins/vis_type_timelion/public/helpers/timelion_request_handler.ts

@@ -93,7 +96,15 @@ export function getTimelionRequestHandler({

 // parse the time range client side to make sure it behaves like other charts
 const timeRangeBounds = timefilter.calculateBounds(timeRange);
- const sessionId = getDataSearch().session.getSessionId();
+ const isCurrentSession = () =>


just interesting, why you defined isCurrentSession as a function and execute it each time.

can we do something like: const isCurrentSession = !!searchSessionId && searchSessionId === dataSearch.session.getSessionId();

we need to "recalculate" it in finally clause because it could already be that when async call finishes dataSearch.session.getSessionId(); has changed.
technically it won't be a problem to call untrack in that case either, but I am doing it for sanity, mostly to make it easier to debug the internal current session state by not calling untrack where we know it is not necessary

src/plugins/vis_type_timelion/public/helpers/timelion_request_handler.ts

src/plugins/vis_type_timeseries/public/request_handler.ts

…sc-integrations

Dosant · 2021-01-12T11:56:04Z

src/plugins/data/public/search/search_interceptor.test.ts

 fetchMock.mockReset();
 });

- test('infers isRestore from session service state', async () => {


These tests were moved into session_service together with underlying logic.

src/plugins/data/public/search/session/session_service.test.ts

src/plugins/vis_type_timeseries/public/request_handler.ts

src/plugins/vis_type_timelion/public/helpers/timelion_request_handler.ts

src/plugins/vis_type_timeseries/common/vis_schema.ts

alexwizp

LGTM in case of green CI

…sc-integrations # Conflicts: # src/plugins/data/public/search/session/session_service.test.ts # src/plugins/data/public/search/session/session_service.ts

stratoula

Kibana app code changes LGTM, thanx for that @Dosant!

Dosant · 2021-01-13T11:20:03Z

@elasticmachine merge upstream

lizozom

Haven't checked out.
Overall LGTM

Dosant · 2021-01-13T16:44:10Z

@elasticmachine merge upstream

kibanamachine · 2021-01-13T19:00:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ced4520

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	1003.6KB	1003.8KB	+138.0B
`dataEnhanced`	39.4KB	39.4KB	+39.0B
`visTypeTimelion`	34.8KB	36.3KB	+1.5KB
`visTypeTimeseries`	137.0KB	137.4KB	+484.0B
`visTypeVega`	60.5KB	60.7KB	+137.0B
total			+2.3KB

History

💚 Build #98508 succeeded 8aa0a64
💚 Build #98247 succeeded a5c7548
💚 Build #98210 succeeded 2edf0e2
💛 Build #98191 was flaky 0b24d18
💔 Build #98171 failed 0816148

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…87862)

…88254)

fix search sesion integration in vega, timelion, timeseries

dcaacca

Dosant changed the title ~~fix search sesion integration in vega, timelion, timeseries~~ [Search Session] Fix integration in vega, timelion and TSVB Jan 11, 2021

Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:AppServices v7.12.0 v8.0.0 Feature:Search Querying infrastructure in Kibana labels Jan 11, 2021

Dosant marked this pull request as ready for review January 11, 2021 21:16

Dosant requested a review from a team January 11, 2021 21:16

Dosant requested review from alexwizp, lukasolson, stratoula and lizozom January 11, 2021 21:17

alexwizp reviewed Jan 12, 2021

View reviewed changes

src/plugins/vis_type_timelion/public/helpers/timelion_request_handler.ts Outdated Show resolved Hide resolved

alexwizp reviewed Jan 12, 2021

View reviewed changes

src/plugins/vis_type_timeseries/public/request_handler.ts Outdated Show resolved Hide resolved

review improvements

48c26ba

Dosant requested a review from a team as a code owner January 12, 2021 10:06

Dosant requested a review from alexwizp January 12, 2021 10:07

Dosant added 2 commits January 12, 2021 11:13

Merge branch 'master' of github.com:elastic/kibana into dev/search/mi…

0816148

…sc-integrations

tests

0b24d18

Dosant commented Jan 12, 2021

View reviewed changes

alexwizp reviewed Jan 12, 2021

View reviewed changes

src/plugins/data/public/search/session/session_service.test.ts Outdated Show resolved Hide resolved

alexwizp reviewed Jan 12, 2021

View reviewed changes

src/plugins/vis_type_timeseries/public/request_handler.ts Show resolved Hide resolved

fix nit in tests

2edf0e2

lizozom reviewed Jan 12, 2021

View reviewed changes

src/plugins/vis_type_timelion/public/helpers/timelion_request_handler.ts Show resolved Hide resolved

src/plugins/vis_type_timeseries/common/vis_schema.ts Outdated Show resolved Hide resolved

alexwizp approved these changes Jan 12, 2021

View reviewed changes

Dosant added 2 commits January 12, 2021 15:53

improve api schema

3f6ec66

Merge branch 'master' of github.com:elastic/kibana into dev/search/mi…

18bfd87

…sc-integrations # Conflicts: # src/plugins/data/public/search/session/session_service.test.ts # src/plugins/data/public/search/session/session_service.ts

docs

a5c7548

Dosant requested a review from lizozom January 13, 2021 10:15

stratoula approved these changes Jan 13, 2021

View reviewed changes

Merge branch 'master' into dev/search/misc-integrations

8aa0a64

lizozom approved these changes Jan 13, 2021

View reviewed changes

Merge branch 'master' into dev/search/misc-integrations

ced4520

Dosant merged commit febe1f5 into elastic:master Jan 13, 2021

Dosant added a commit to Dosant/kibana that referenced this pull request Jan 13, 2021

[Search Session] Fix integration in vega, timelion and TSVB (elastic#…

7ece422

…87862)

Dosant mentioned this pull request Jan 13, 2021

[7.x] [Search Session] Fix integration in vega, timelion and TSVB (#87862) #88254

Merged

Dosant added a commit that referenced this pull request Jan 14, 2021

[Search Session] Fix integration in vega, timelion and TSVB (#87862) (#…

30081e4

…88254)

Dosant mentioned this pull request Jan 19, 2021

[Search] Send to background #83640

Closed

38 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Search Session] Fix integration in vega, timelion and TSVB #87862

[Search Session] Fix integration in vega, timelion and TSVB #87862

Dosant commented Jan 11, 2021 •

edited

Loading

elasticmachine commented Jan 11, 2021

alexwizp Jan 12, 2021

Dosant Jan 12, 2021 •

edited

Loading

Dosant Jan 12, 2021

alexwizp left a comment

stratoula left a comment

Dosant commented Jan 13, 2021

lizozom left a comment

Dosant commented Jan 13, 2021

kibanamachine commented Jan 13, 2021

[Search Session] Fix integration in vega, timelion and TSVB #87862

[Search Session] Fix integration in vega, timelion and TSVB #87862

Conversation

Dosant commented Jan 11, 2021 • edited Loading

Summary

How to test

For maintainers

elasticmachine commented Jan 11, 2021

alexwizp Jan 12, 2021

Choose a reason for hiding this comment

Dosant Jan 12, 2021 • edited Loading

Choose a reason for hiding this comment

Dosant Jan 12, 2021

Choose a reason for hiding this comment

alexwizp left a comment

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

Dosant commented Jan 13, 2021

lizozom left a comment

Choose a reason for hiding this comment

Dosant commented Jan 13, 2021

kibanamachine commented Jan 13, 2021

💚 Build Succeeded

Metrics [docs]

Page load bundle

History

Dosant commented Jan 11, 2021 •

edited

Loading

Dosant Jan 12, 2021 •

edited

Loading