Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Add APM, uptime and create alert links to overlay #87883

Merged
merged 2 commits into from
Jan 12, 2021
Merged

[Metrics UI] Add APM, uptime and create alert links to overlay #87883

merged 2 commits into from
Jan 12, 2021

Conversation

phillipb
Copy link
Contributor

Summary

Fixes #87818.

Screen Shot 2021-01-11 at 11 43 11 AM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@phillipb phillipb added bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 labels Jan 11, 2021
@phillipb phillipb requested a review from a team as a code owner January 11, 2021 17:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@phillipb phillipb added the release_note:skip Skip the PR/issue when compiling release notes label Jan 11, 2021
Zacqary
Zacqary approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.7MB 2.7MB +2.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@phillipb phillipb merged commit f54f155 into elastic:master Jan 12, 2021
@phillipb phillipb mentioned this pull request Jan 12, 2021
Merged
phillipb added a commit to phillipb/kibana that referenced this pull request Jan 12, 2021
@phillipb
[Metrics UI] Add APM, uptime and create alert links to overlay (elast…
b869beb 
…ic#87883)

* Add APM, uptime and create alert links to overlay

* Remove unused i18n
phillipb added a commit that referenced this pull request Jan 12, 2021
@phillipb
[Metrics UI] Add APM, uptime and create alert links to overlay (#87883)…
c8bdc7a 
… (#87951)

* Add APM, uptime and create alert links to overlay

* Remove unused i18n
phillipb added a commit to phillipb/kibana that referenced this pull request Jan 12, 2021
@phillipb
[Metrics UI] Add APM, uptime and create alert links to overlay (elast…
c6f4ef4 
…ic#87883)

* Add APM, uptime and create alert links to overlay

* Remove unused i18n
@phillipb phillipb mentioned this pull request Jan 12, 2021
Merged
phillipb added a commit that referenced this pull request Jan 12, 2021
@phillipb @kibanamachine
[Metrics UI] Add APM, uptime and create alert links to overlay (#87883)…
c5c17cb 
… (#88004)

* Add APM, uptime and create alert links to overlay

* Remove unused i18n

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zacqary Zacqary Zacqary approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Revert to host dropdown
4 participants
@phillipb @elasticmachine @kibanamachine @Zacqary