Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM] Surface linked hidden indices for policy #87960

Merged

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Jan 12, 2021

Fixes #87897

An ILM policy associated to a hidden data stream would show "0" for linked indices and allow deletion in the UI, when it should be disabled. This bug does not exist on 7.10, so skipping release note. I think it is related to the introduction of hidden data streams via elastic/elasticsearch#63987.

How to test

This can be tested against the ilm-history-ilm-policy or the watch-history-ilm-policy policies. You can also create your own policy with a hidden data stream as outlined below:

  1. Create a hidden data stream, using the following commands in Console:
PUT _index_template/my_template
{
  "template": {},
  "index_patterns": [
    "foo"
  ],
  "data_stream": {
    "hidden": true   
  }
}
POST foo/_doc
{
  "@timestamp": "2020-01-27"
}
  1. Create an ILM policy through the UI (only name is required)
  2. Go to Index Management, find the backing index for the data stream created in step 1 and open the details panel. Click "Manage" and select "Add lifecycle policy".
  3. Go back to ILM UI and verify the policy shows there is a linked index and deletion is disabled.

Screen Shot 2021-01-11 at 9 38 56 PM

@alisonelizabeth alisonelizabeth added Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 labels Jan 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #98126 succeeded 1fd9caf42ed21544dee41fcf231a3c3088dce81d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @alisonelizabeth ! I tested locally and the fix worked. Great job adding API integration tests too 👍
While I was testing though, I noticed that while the link to Index Management works, the indices list there is not including the correct ILM information for backing indices of a hidden data stream. I believe the same fix is needed here. I'll create an issue for that.

@alisonelizabeth
Copy link
Contributor Author

While I was testing though, I noticed that while the link to Index Management works, the indices list there is not including the correct ILM information for backing indices of a hidden data stream. I believe the same fix is needed here. I'll create an issue for that.

Great catch @yuliacech! I think you're correct. Thanks for opening up an issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ILM] - Delete button is enabled for the ILM policies created by ES.
4 participants