Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Remove circular deps between KibanaApp team plugins #87994

Merged
merged 6 commits into from
Jan 13, 2021
Merged

[Visualize] Remove circular deps between KibanaApp team plugins #87994

merged 6 commits into from
Jan 13, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jan 12, 2021 •
edited
Loading

Part of #84750

Summary

This PR is a follow-up to PR related to removing dependencies between Kibana App plugins.
What was done in that PR:

  • visualization plugin setup API was changed. Now instead of one setDefaultEditor method it returns extended visEditorsRegistry object with inner registerDefault, register, get methods . Thanks @sulemanof for that idea
  • editor property was removed from the VisType. Now if we need to set a custom editor for some visualization it should be passed into editorConfig.editor as a string. Important: custom editor should be registered using visEditorsRegistry.register before using.
  • IEditorController, EditorRenderProps was moved into visualize plugin

@alexwizp alexwizp requested review from sulemanof, stratoula and timroes and removed request for sulemanof January 12, 2021 11:08
@alexwizp alexwizp self-assigned this Jan 12, 2021
@alexwizp alexwizp added v7.12.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 12, 2021
sulemanof
sulemanof approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🎉
That's what I was talking about 💞
FMPOV looks much more better now, a step forward to making the visualize to be an optional plugin

src/plugins/vis_type_timeseries/kibana.json Show resolved Hide resolved
@alexwizp alexwizp marked this pull request as ready for review January 12, 2021 13:56
@alexwizp alexwizp requested a review from a team January 12, 2021 13:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visualize 78 80 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualize 132.0KB 132.3KB +289.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visDefaultEditor 44.3KB 44.3KB +18.0B
visTypeTimeseries 136.8KB 137.0KB +144.0B
visualizations 171.0KB 171.0KB -62.0B
visualize 42.3KB 43.0KB +654.0B
total +754.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula
stratoula approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Much better this way, great enhancement 🎉

@alexwizp alexwizp merged commit 703ac93 into elastic:master Jan 13, 2021
@alexwizp alexwizp mentioned this pull request Jan 13, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jan 13, 2021
@alexwizp @kibanamachine
[Visualize] Remove circular deps between KibanaApp team plugins (elas…
03f9c16 
…tic#87994)

* [Visualize] Remove circular deps between KibanaApp team plugins

Part of elastic#84750

* Update use_vis_byvalue.ts

* Update use_saved_vis_instance.ts

* add types

* fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp added a commit that referenced this pull request Jan 13, 2021
@alexwizp @kibanamachine
[Visualize] Remove circular deps between KibanaApp team plugins (#87994…
f016285 
…) (#88141)

* [Visualize] Remove circular deps between KibanaApp team plugins

Part of #84750

* Update use_vis_byvalue.ts

* Update use_saved_vis_instance.ts

* add types

* fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulemanof sulemanof sulemanof approved these changes

@stratoula stratoula stratoula approved these changes

@timroes timroes Awaiting requested review from timroes

Assignees

@alexwizp alexwizp

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexwizp @elasticmachine @kibanamachine @stratoula @sulemanof