-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Shift polling interval by random amount when Task Manager experiences consistent claim version conflicts #88020
[Alerting] Shift polling interval by random amount when Task Manager experiences consistent claim version conflicts #88020
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
x-pack/plugins/task_manager/server/polling/delay_on_claim_conflicts.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! Tested locally and saw 2/3 of Kibana instances delaying their polling when they were previously in sync. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node a typo, and have a question about the "initial delay" in the new timer()
usage. Likely my Rx inexperience showing :-)
Otherwise, LGTM.
…mmorris/kibana into tm/shift-polling-on-persistent-clashes * 'tm/shift-polling-on-persistent-clashes' of github.com:gmmorris/kibana: typo
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…experiences consistent claim version conflicts (elastic#88020) This PR Introduces a `pollingDelay` which is applied to the polling interval whenever the average percentage of tasks experiencing a version conflict is higher than a preconfigured threshold (default to 80%).
…experiences consistent claim version conflicts (elastic#88020) This PR Introduces a `pollingDelay` which is applied to the polling interval whenever the average percentage of tasks experiencing a version conflict is higher than a preconfigured threshold (default to 80%).
Added Docs for this into the Scaling docs in ad4fde6 |
Summary
Closes #87808
This PR Introduces a
pollingDelay
which is applied to the polling interval whenever the average percentage of tasks experiencing a version conflict is higher than a preconfigured threshold (default to 80%).Notes:
delayOnClaimConflicts
function and the Monitoring Stats components. I've kept these apart on purpose to avoid changing unnecessary code as part of this PR due to it being a post-FF fix.Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportAny UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)This was checked for cross-browser compatibilityFor maintainers