Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [EventLog] Added event log API to get events for multiple saved objects. (#87596) #88116

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

YulNaumenko
Copy link
Contributor

Backports the following commits to 7.x:

…ts. (elastic#87596)

* Added alerting API to get all active instances

* modofied event log findEventsBySavedObject to support bulk ids, renamed to findEventsBySavedObjectIds

* fixed faling typechecks

* fixed crash on zpd/api/event_log/alert/84c00970-5130-11eb-9fa7/_find for non existing id

* fixed faling typechecks

* fixed faling typechecks

* fixed due to comments

* fixed due to comments

* fixed failing test

* fixed due to comments
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

X-Pack Case API Integration Tests.x-pack/test/case_api_integration/basic/tests/cases/tags/get_tags·ts.case api basic get_tags should return case tags

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: case api basic
[00:00:00]           └-> "before all" hook
[00:04:59]           └-: get_tags
[00:04:59]             └-> "before all" hook
[00:04:59]             └-> should return case tags
[00:04:59]               └-> "before each" hook: global before each
[00:05:03]               └- ✖ fail: case api basic get_tags should return case tags
[00:05:03]               │       Error: expected [ 'unique', 'defacement' ] to sort of equal [ 'defacement', 'unique' ]
[00:05:03]               │       + expected - actual
[00:05:03]               │ 
[00:05:03]               │        [
[00:05:03]               │       +  "defacement"
[00:05:03]               │          "unique"
[00:05:03]               │       -  "defacement"
[00:05:03]               │        ]
[00:05:03]               │       
[00:05:03]               │       at Assertion.assert (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:100:11)
[00:05:03]               │       at Assertion.eql (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:244:8)
[00:05:03]               │       at Context.<anonymous> (test/case_api_integration/basic/tests/cases/tags/get_tags.ts:38:23)
[00:05:03]               │       at Object.apply (/dev/shm/workspace/parallel/2/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)
[00:05:03]               │ 
[00:05:03]               │ 

Stack Trace

Error: expected [ 'unique', 'defacement' ] to sort of equal [ 'defacement', 'unique' ]
    at Assertion.assert (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.<anonymous> (test/case_api_integration/basic/tests/cases/tags/get_tags.ts:38:23)
    at Object.apply (/dev/shm/workspace/parallel/2/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16) {
  actual: '[\n  "unique"\n  "defacement"\n]',
  expected: '[\n  "defacement"\n  "unique"\n]',
  showDiff: true
}

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit 6d10eef into elastic:7.x Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants