Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Change cloud messaging on no data page #88375

Merged
merged 5 commits into from
Jan 15, 2021
Merged

[Monitoring] Change cloud messaging on no data page #88375

merged 5 commits into from
Jan 15, 2021

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Jan 14, 2021 •
edited
Loading

Relates to #85990

In #85990, we noticed that cloud has officially migrated from legacy collection to Metricbeat collection and we need to take away the option for users to enable legacy collection in the UI.

@chrisronline chrisronline self-assigned this Jan 14, 2021
@chrisronline chrisronline requested a review from a team January 14, 2021 19:12
@chrisronline chrisronline marked this pull request as ready for review January 14, 2021 19:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline chrisronline mentioned this pull request Jan 14, 2021
Closed
1 task
@ravikesarwani
Copy link
Contributor

ravikesarwani commented Jan 14, 2021 •
edited
Loading

For messaging we can use something like [Configure monitoring through Elasticsearch Service Console. Go to Logs and metrics section for a deployment to configure monitoring. For more information visit the documentation page.] We can add deep links as much as available.

@chrisronline
Copy link
Contributor Author

@ravikesarwani

How about:

Screen Shot 2021-01-14 at 11 22 49 AM

@ravikesarwani
Copy link
Contributor

If it's easy to update the message then it would helpful. I tried to use terms that are used elsewhere (Elasticsearch service console) and provides more specific information (logs and metrics) where to go for configuring monitoring.

@chrisronline
Copy link
Contributor Author

@ravikesarwani Yea I don't think we can truly deep link but we can link to the deployments page and we have total control over the messaging you see in the screenshot. Happy to change it to whatever you want. Just lemme know

@ravikesarwani
Copy link
Contributor

How about this?
Configure monitoring through Elasticsearch Service Console. Go to "Logs and metrics" section for a deployment to configure monitoring. For more information visit the documentation page.

@chrisronline
Copy link
Contributor Author

Updated and I also took out the second header, seemed to wordy.

Lemme know!

Screen Shot 2021-01-14 at 3 35 06 PM

@ravikesarwani
Copy link
Contributor

Thanks, looks good. Short and sweet.

@ravikesarwani
Copy link
Contributor

Sorry, was wondering if we should change the top message "Monitoring is currently off" in the Cloud since we do not know if monitoring is enabled. All we know that there's no monitoring data to show.

Maybe we change that top message to say "Monitoring data not available". WDYT?

@chrisronline
Copy link
Contributor Author

chrisronline commented Jan 15, 2021 •
edited
Loading

@ravikesarwani

WDYT?

Screen Shot 2021-01-14 at 10 05 13 PM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 981.3KB 983.2KB +2.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

igoristic
igoristic approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrisronline chrisronline merged commit 68288eb into elastic:master Jan 15, 2021
@chrisronline chrisronline deleted the monitoring/cloud_messaging branch January 15, 2021 18:43
@chrisronline chrisronline mentioned this pull request Jan 15, 2021
Merged
@chrisronline chrisronline mentioned this pull request Jan 15, 2021
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 15, 2021
@chrisronline
[Monitoring] Change cloud messaging on no data page (elastic#88375)
cf22ff7 
* WIP

* Update tests

* Update copy

* Fix translations and update copy

* Fix tests and update copy
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 15, 2021
@chrisronline
[Monitoring] Change cloud messaging on no data page (elastic#88375)
e15f0e9 
* WIP

* Update tests

* Update copy

* Fix translations and update copy

* Fix tests and update copy
chrisronline added a commit that referenced this pull request Jan 15, 2021
@chrisronline
[7.11] [Monitoring] Change cloud messaging on no data page (#88375) (#…
5bc517c 
…88508)

* [Monitoring] Change cloud messaging on no data page (#88375)

* WIP

* Update tests

* Update copy

* Fix translations and update copy

* Fix tests and update copy

* Fix missing import
chrisronline added a commit that referenced this pull request Jan 15, 2021
@chrisronline
[7.x] [Monitoring] Change cloud messaging on no data page (#88375) (#…
5cbe6ff 
…88507)

* [Monitoring] Change cloud messaging on no data page (#88375)

* WIP

* Update tests

* Update copy

* Fix translations and update copy

* Fix tests and update copy

* Fix missing import
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 18, 2021
@gmmorris
Merge branch 'master' into tm/cancel-expired-tasks-on-hung-tm
1ded8b6 
* master: (33 commits)
  [Security Solution][Case] Fix patch cases integration test with alerts (elastic#88311)
  [Security Solutions][Detection Engine] Removes duplicate API calls (elastic#88420)
  Fix log msg (elastic#88370)
  [Test] Add tag cloud visualization to dashboard in functional test for reporting (elastic#87600)
  removing kibana-core-ui from codeowners (elastic#88111)
  [Alerting] Migrate Event Log plugin to TS project references (elastic#81557)
  [Maps] fix zooming while drawing shape filter logs errors in console (elastic#88413)
  Porting fixes 1 (elastic#88477)
  [APM] Explicitly set environment for cross-service links (elastic#87481)
  chore(NA): remove mocha junit ci integrations (elastic#88129)
  [APM] Only display relevant sections for rum agent in service overview (elastic#88410)
  [Enterprise Search] Automatically mock shared logic files (elastic#88494)
  [APM] Disable Create custom link button on Transaction details page for read-only users
  [Docs] clean-up vega map reference documenation (elastic#88487)
  [Security Solution] Fix Timeline event details layout (elastic#88377)
  Change DELETE to POST for _bulk_delete to avoid incompatibility issues (elastic#87914)
  [Monitoring] Change cloud messaging on no data page (elastic#88375)
  [Uptime] clear ping state when PingList component in unmounted (elastic#88321)
  [APM] Consistent terminology for latency and throughput (elastic#88452)
  fix copy (elastic#88481)
  ...
@chrisronline chrisronline mentioned this pull request Jan 27, 2021
Merged
@simianhacker simianhacker mentioned this pull request Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoristic igoristic igoristic approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:fix review Team:Monitoring Stack Monitoring team v7.11.0 v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisronline @elasticmachine @ravikesarwani @kibanamachine @igoristic