Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Automatically mock shared logic files #88494

Merged
merged 17 commits into from
Jan 15, 2021
Merged

[Enterprise Search] Automatically mock shared logic files #88494

merged 17 commits into from
Jan 15, 2021

Commits on Jan 15, 2021

  1. Update shared logic mocks to automatically mock their exports

    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    93b7242 View commit details
    Browse the repository at this point in the history

  2. Update FlashMessages to also mock its helper fns

    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    8adabf3 View commit details
    Browse the repository at this point in the history

  3. Fix tests that were relying on component exports from shared logic files

    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    e30bab9 View commit details
    Browse the repository at this point in the history

  4. Fix broken flash_messages tests 

    - Caused by leaking auto mocks - work around this by importing from files directly and not from index.ts

- Also clean up / use new auto mocks (e.g. for kibana)

- Convert old instances of useValues mock to setMockValues
    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    b49b877 View commit details
    Browse the repository at this point in the history

  5. [AS] Update AnalyticsLogic test to use new auto mockers 

    + move LogicMounter and destructured mock values to top of describe block
    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    be5ad45 View commit details
    Browse the repository at this point in the history

  6. [AS] Update CredentialsLogic 

    + udpate to use new clearFlashMessages helper
    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    6ab0558 View commit details
    Browse the repository at this point in the history

  7. [AS] Update documents logic tests

    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    e3f27b1 View commit details
    Browse the repository at this point in the history

  8. [AS] Update engines logic tests

    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    9560903 View commit details
    Browse the repository at this point in the history

  9. [AS] Update log retention logic test

    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    f704a9b View commit details
    Browse the repository at this point in the history

  10. [Shared] Update IndexingStatus tests 

    + update to use LogicMounter
    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    a64d289 View commit details
    Browse the repository at this point in the history

  11. [Shared] Update telemetry logic test

    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    209b957 View commit details
    Browse the repository at this point in the history

  12. [WS] Update AddSourceLogic 

    + update to use new clearFlashMessages helper
    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    ebc7b94 View commit details
    Browse the repository at this point in the history

  13. [WS] Update groups logic files 

    + update to use new flash message helpers
    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    bc844f5 View commit details
    Browse the repository at this point in the history

  14. [WS] Update OverviewLogic test

    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    3b3c157 View commit details
    Browse the repository at this point in the history

  15. [WS] Update AddSource component test 

    + consolidate mocks imports
    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    dea5389 View commit details
    Browse the repository at this point in the history

  16. [Shared] Clean up KibanaLogic imports 

    - all jest.mocks come along from the ride when the __mocks__ folder is imported, so HttpLogic is now automatically already mocked
    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    f132f2d View commit details
    Browse the repository at this point in the history

  17. [AS] Update EngineRouter test

    @cee-chen
    cee-chen committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    ecc0148 View commit details
    Browse the repository at this point in the history