Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] EMS baselayer should load cleanly #88531

Merged
merged 7 commits into from
Jan 19, 2021

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Jan 15, 2021

Summary

Closes #88515

This bug was "revealed" by #87310.

vector_tile_layer was loading the EMS-meta twice in short succession due to not correctly setting the metadata of the request. This did not cause end-user errors, just a double refresh cycle internally.

By introducing #87310, the second refresh would throw an error, causing the layer-error to show up in the TOC.

The fix is that vector_tile_layer should correctly set the metadata about the request. This way, the canSkip logic behaves as expected and there is no 2nd redundant refresh.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@thomasneirynck thomasneirynck added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.11.1 v7.12.0 v8.0.0 labels Jan 15, 2021
@thomasneirynck thomasneirynck marked this pull request as ready for review January 15, 2021 21:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

tested in Chrome

@thomasneirynck thomasneirynck requested a review from nreese January 19, 2021 16:31
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing this
code review

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.9MB 2.9MB -36.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 66c0cc2 into elastic:master Jan 19, 2021
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jan 19, 2021
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jan 19, 2021
thomasneirynck added a commit that referenced this pull request Jan 20, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
thomasneirynck added a commit that referenced this pull request Jan 20, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.11.1 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Baselayer loads slowly - showing error
5 participants